1721971 - Disable multi-page login forms support on release channel

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P1)

Description

[Dimi Lee [ooo 16.04 - 21.04］]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1708455#c19

Comment 1

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 1721971 - Disable multi-page login forms support on release channel r=sfoster,tgiles

Comment 2

[Pascal Chevrel:pascalc]

Dimi, this needs to land and uplift to beta real soon, our last beta builds on Thursday and we build our RC next Monday. Thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34338bfd24c4
Disable multi-page login forms support on release channel r=tgiles

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Pascal Chevrel:pascalc from comment #2)

Dimi, this needs to land and uplift to beta real soon, our last beta builds on Thursday and we build our RC next Monday. Thanks

Thank you for reminding, Pascal! I was on PTO so didn't land this earlier .

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/34338bfd24c4

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 9232789 [details]
Bug 1721971 - Disable multi-page login forms support on release channel r=sfoster,tgiles

Beta/Release Uplift Approval Request

• User impact if declined: In some sites, the autocomplete popup for login might be shown in a non-username field
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because this is only to turn off the multi-page login form support
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9232789 [details]
Bug 1721971 - Disable multi-page login forms support on release channel r=sfoster,tgiles

Approved for our last beta, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/b73436a1226e

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/cf1a0523fb01
Backed out for causing permanent failures on beta

https://treeherder.mozilla.org/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=bc&revision=68ec3b4d7a253d28b33491b7b1c89c2cd5dcde9e&selectedTaskRun=UFjgIaifSVyyY4n-VwW4GQ.0
and
https://treeherder.mozilla.org/jobs?repo=mozilla-beta&selectedTaskRun=dt3hNMyuT2GEW-8wMCgboQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=68ec3b4d7a253d28b33491b7b1c89c2cd5dcde9e&searchStr=xpc

Comment 10

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: Bug 1721971 - Disable multi-page login forms support on release channel r=sfoster,tgiles

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9233696 [details]
Bug 1721971 - Disable multi-page login forms support on release channel r=sfoster,tgiles

Approved for beta, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/13642a3bf80c

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:
The changes setting the preference in the tests to prevents failures for late beta and release still need to land on central.

Comment 14

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pascal Chevrel:pascalc (pto until August 23) from comment #8)

https://hg.mozilla.org/releases/mozilla-beta/rev/b73436a1226e

== Change summary for alert #30748 (as of Mon, 02 Aug 2021 14:14:17 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
13%	web-de	fnbpaint	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	358.83 -> 310.62
13%	web-de	fcp	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	316.81 -> 276.46
9%	web-de	FirstVisualChange	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	456.83 -> 414.83

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30748

Comment 15

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pascal Chevrel:pascalc (pto until August 23) from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/cf1a0523fb01
Backed out for causing permanent failures on beta

== Change summary for alert #30789 (as of Thu, 05 Aug 2021 04:20:00 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
12%	web-de	fcp	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	275.71 -> 308.83

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30789

Comment 16

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pascal Chevrel:pascalc (pto until August 23) from comment #12)

https://hg.mozilla.org/releases/mozilla-beta/rev/13642a3bf80c

== Change summary for alert #30778 (as of Wed, 04 Aug 2021 13:35:39 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
13%	web-de	fcp	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	311.04 -> 269.96

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30778