1722031 - Ship accent-color

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1722031 - Fix RelativeLuminanceUtils::Adjust to not choke on blacks / zero components. r=mstange

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1722031 - Fix RelativeLuminanceUtils::Adjust to not choke on blacks / zero components. r=mstange

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1722031 - Tweak accent-color foreground computation and let it ride the trains. r=mstange

The accent-color computation right now chooses between black and white,
which is not ideal.

I tried to make it so that authors could choose the foreground colors in
the linked CSSWG issue from the comment, but that didn't go anywhere.

I think choosing a contrasting color that is in-line and contrasting
enough with the accent-color chosen by the page when darkening is better
than just black or white.

If we want the black-or-white behavior we can just change
layout.css.accent-color.target-contrast-ratio to something large enough.

https://accent-color.glitch.me/ is a nice playground to see this patch
in action.

Depends on D120722

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1722031 - Fix an accent-color test. r=mstange

No other property returns currentcolor in the computed style, and
Chrome agrees with us on this test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a0274aa4014
Fix an accent-color test. r=mstange

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef0ebe9d47b3
Fix RelativeLuminanceUtils::Adjust to not choke on blacks / zero components. r=mstange
https://hg.mozilla.org/integration/autoland/rev/7a7d9a6cc513
Tweak accent-color foreground computation and let it ride the trains. r=mstange

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29776 for changes under testing/web-platform/tests

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2a0274aa4014
https://hg.mozilla.org/mozilla-central/rev/ef0ebe9d47b3
https://hg.mozilla.org/mozilla-central/rev/7a7d9a6cc513

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Rachel Andrew]

I've updated BCD and release notes: https://github.com/mdn/content/issues/7752