1722087 - Large unused theme images still in omni.jar

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Greg Tatum [:gregtatum]]

I was poking around the omni.jar and found some theme images that appear to be unused. They total 1.4MB in size.

browser/base/content/defaultthemes/1.header.jpg
browser/base/content/defaultthemes/1.icon.jpg
browser/base/content/defaultthemes/1.preview.jpg
browser/base/content/defaultthemes/2.header.jpg
browser/base/content/defaultthemes/2.icon.jpg
browser/base/content/defaultthemes/2.preview.jpg
browser/base/content/defaultthemes/3.header.png
browser/base/content/defaultthemes/3.icon.png
browser/base/content/defaultthemes/3.preview.png
browser/base/content/defaultthemes/4.header.png
browser/base/content/defaultthemes/4.icon.png
browser/base/content/defaultthemes/4.preview.png
browser/base/content/defaultthemes/5.header.png
browser/base/content/defaultthemes/5.icon.jpg
browser/base/content/defaultthemes/5.preview.jpg

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1722087 - Save 1.4M in omnijar by removing unused theme images; r?#desktop-theme-reviewers,mstriemer

Comment 2

[Greg Tatum [:gregtatum]]

Feel free to redirect the component or reviews if there is a more appropriate place for this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc08ab00539b
Save 1.4M in omnijar by removing unused theme images; r=desktop-theme-reviewers,harry

Comment 4

[:Gijs (he/him)]

So uh, yeah, these files were part of a recommended themes feature - but we didn't then install from AMO, we installed locally, and so I think if users used these builtin themes previously, they will now encounter breakage because the requisite files will have gone AWOL.

Can you file a follow-up to migrate such people back to the default theme, rather than break their Firefox (or, if that's not likely to happen before soft freeze on Thursday, perhaps consider asking for a backout on this patch and relanding it when we're sure we won't break those users)?

See also how when we previously reduced the list of available custom themes, we didn't remove the older images: https://hg.mozilla.org/mozilla-central/rev/06bced347abc

and the pre-existing discussion in bug 1370919.

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cc08ab00539b

Comment 6

[Harry Twyford]

Clearing needinfo because Greg has this handled in bug 1723602.

Comment 7

[Greg Tatum [:gregtatum]]

I have a patch in Bug 1723602 to migrate users. If that's not landed or acceptable approach, then we can back this one out.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out from beta for causing issues if users still have old theme set as active (bug 1723602):
https://hg.mozilla.org/releases/mozilla-beta/rev/73a94947399c