1722097 - OpenPGP MsgHdrViewOverlay isCurrentMessage(), currUrl may be null

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

From bug 1707517 comment 9:

'''
TypeError: currUrl is null
isCurrentMessage chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:934
handleSMimeMessage chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:1244
handleSmime chrome://openpgp/content/modules/pgpmimeHandler.jsm:240
onStartRequest chrome://openpgp/content/modules/pgpmimeHandler.jsm:202
enigmailMsgHdrViewOverlay.js:934:1
'''

We should avoid the exception.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1722097 - Fail gracefull if we fail to extract URL attributes enigmailMsgHdrViewOverlay.js isCurrentMessage(). r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6177d7407da
Fail gracefull if we fail to extract URL attributes enigmailMsgHdrViewOverlay.js isCurrentMessage(). r=mkmelin

Comment 3

[Uplift Request]

Please request 92 (and later 91) uplift.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9232914 [details]
Bug 1722097 - Fail gracefull if we fail to extract URL attributes enigmailMsgHdrViewOverlay.js isCurrentMessage(). r=mkmelin

[Approval Request Comment]
User impact if declined: pointless console spew
Testing completed (on c-c, etc.): yes on c-c
Risk to taking this patch (and alternatives if risky): Not risky, just avoiding errors in the console.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9232914 [details]
Bug 1722097 - Fail gracefull if we fail to extract URL attributes enigmailMsgHdrViewOverlay.js isCurrentMessage(). r=mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/607150ad89a1

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9232914 [details]
Bug 1722097 - Fail gracefull if we fail to extract URL attributes enigmailMsgHdrViewOverlay.js isCurrentMessage(). r=mkmelin

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.0.3:
https://hg.mozilla.org/releases/comm-esr91/rev/0270f257d8e9