Closed Bug 1722104 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 29770 - Clean up maxBufferSize JS Self-Profiling API WPT

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox92 fixed)

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29770 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29770
Details from upstream follow.

b'Andrew Comminos <acomminos@fb.com>' wrote:

Clean up maxBufferSize JS Self-Profiling API WPT

Remove erroneous assertTrue call, make profiler naming more descriptive,
and switch to .window.js style test to reduce boilerplate.

Bug: 956688
Change-Id: I320650ad08e319542e1d97aba4a582700973a63e
Reviewed-on: https://chromium-review.googlesource.com/3050091
WPT-Export-Revision: ba54b9cfa1d7425608407e6770e3e4dd0110869f

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
PASS: 3

Safari

OK : 1
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/js-self-profiling/max-buffer-size.window.html
max buffer size must be defined: FAIL (Chrome: PASS, Safari: FAIL)
max buffer size is not exceeded: FAIL (Chrome: PASS, Safari: FAIL)
ensure samplebufferfull is fired on full profiler: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/152cee078287 [wpt PR 29770] - Clean up maxBufferSize JS Self-Profiling API WPT, a=testonly https://hg.mozilla.org/integration/autoland/rev/76ccc8f04a74 [wpt PR 29770] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ba34772fcb1 [wpt PR 29770] - Clean up maxBufferSize JS Self-Profiling API WPT, a=testonly https://hg.mozilla.org/integration/autoland/rev/8efed36b27fb [wpt PR 29770] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7ba34772fcb1
https://hg.mozilla.org/mozilla-central/rev/8efed36b27fb

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.