1722232 - Revert the local cairo fix from bug 1717685 and take the version that was merged upstream in preference

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Kew [:jfkthame]]

In bug 1717685 we landed a patch to avoid a spurious cairo assertion that fuzz-testing found. After discussion with the upstream developers, a slightly different version of the fix was applied in https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/195.

(The original fix in bug 1717685 may be flawed because it fails to set the command->header.region field; I guess this could lead to subsequent incorrect behavior/rendering, though in practice this probably only happens on testcases with such extreme coordinates/transforms that no sensible rendering is likely anyhow.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1722232 - Revert changeset 5689add84fe2 (bug 1717685) and take the upstream version of the fix from https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/195 instead. r=jrmuizel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f02e38dccb1c
Revert changeset 5689add84fe2 (bug 1717685) and take the upstream version of the fix from https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/195 instead. r=jrmuizel

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f02e38dccb1c