1722268 - Almost permanent Windows asan AvailableMemoryWatcherFixture.InactiveToActive | Value of: WaitUntil([this]() { return mTabUnloader->GetCounter() >= 1; }, kStateChangeTimeoutMs)

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=346316359&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/V4mKZ-0iSHeGyHF5TflWoA/runs/0/artifacts/public/logs/live_backing.log

---

This is a tier 3 failure in Treeherder and not shown by default. Click the "3" in the second toolba from the top to get it shown.

[task 2021-07-26T07:55:42.261Z] 07:55:42     INFO -  TEST-START | AvailableMemoryWatcherFixture.InactiveToActive
[task 2021-07-26T07:55:42.314Z] 07:55:42     INFO -  Setting browser.low_commit_space_threshold_mb to 7710
[task 2021-07-26T07:55:42.341Z] 07:55:42     INFO -  Total physical memory  = 16253l
[task 2021-07-26T07:55:42.341Z] 07:55:42     INFO -  Available commit space = 15420l
[task 2021-07-26T07:55:42.341Z] 07:55:42     INFO -  Amount to allocate     = 13020l
[task 2021-07-26T07:55:42.342Z] 07:55:42     INFO -  Future available commit space after allocation = 2400
[task 2021-07-26T07:55:54.460Z] 07:55:54  WARNING -  TEST-UNEXPECTED-FAIL | AvailableMemoryWatcherFixture.InactiveToActive | Value of: WaitUntil([this]() { return mTabUnloader->GetCounter() >= 1; }, kStateChangeTimeoutMs)
[task 2021-07-26T07:55:54.460Z] 07:55:54     INFO -    Actual: false
[task 2021-07-26T07:55:54.460Z] 07:55:54     INFO -  Expected: true @ /builds/worker/checkouts/gecko/xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp:557
[task 2021-07-26T07:56:07.464Z] 07:56:07  WARNING -  TEST-UNEXPECTED-FAIL | AvailableMemoryWatcherFixture.InactiveToActive | Value of: mHighMemoryObserver->Wait(kStateChangeTimeoutMs)
[task 2021-07-26T07:56:07.464Z] 07:56:07     INFO -    Actual: false
[task 2021-07-26T07:56:07.464Z] 07:56:07     INFO -  Expected: true @ /builds/worker/checkouts/gecko/xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp:568
[task 2021-07-26T07:56:07.480Z] 07:56:07  WARNING -  TEST-UNEXPECTED-FAIL | AvailableMemoryWatcherFixture.InactiveToActive | Expected equality of these values:
[task 2021-07-26T07:56:07.480Z] 07:56:07     INFO -    eventValues.Length()
[task 2021-07-26T07:56:07.481Z] 07:56:07     INFO -      Which is: 0
[task 2021-07-26T07:56:07.481Z] 07:56:07     INFO -    mLastCountOfEvents + 1
[task 2021-07-26T07:56:07.481Z] 07:56:07     INFO -      Which is: 1 @ /builds/worker/checkouts/gecko/xpcom/tests/gtest/TestAvailableMemoryWatcherWin.cpp:470
[task 2021-07-26T07:56:07.493Z] 07:56:07  WARNING -  TEST-UNEXPECTED-FAIL | AvailableMemoryWatcherFixture.InactiveToActive | test completed (time: 25233ms)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1715858

Comment 2

[Chris H-C :chutten]

Changing component to match the regressing bug 1715858

Comment 3

[Toshihito Kikuchi [:toshi]]

Resolving this as there is no new instance.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It's a tier 3 failure and failing almost permanently but not getting classified but tier 3 is not managed by sheriffs (and not shown to them).

Comment 5

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1722268 - Increase the timeout thresholds in AvailableMemoryWatcherFixture. r=gsvelto

Due to slower performance with ASan, this patch increases the thresholds.

Comment 6

[Toshihito Kikuchi [:toshi]]

https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=df99a4f033d289da2ff2307d8a9580b3b5139d47

[task 2021-08-04T15:13:45.579Z] 15:13:45     INFO -  TEST-START | AvailableMemoryWatcherFixture.AlwaysActive
[task 2021-08-04T15:13:45.579Z] 15:13:45     INFO -  Setting browser.low_commit_space_threshold_mb to 7966
[task 2021-08-04T15:13:45.580Z] 15:13:45     INFO -  Total physical memory  = 16253l
[task 2021-08-04T15:13:45.580Z] 15:13:45     INFO -  Available commit space = 15932l
[task 2021-08-04T15:13:45.580Z] 15:13:45     INFO -  Amount to allocate     = 13115l
[task 2021-08-04T15:13:45.580Z] 15:13:45     INFO -  Future available commit space after allocation = 2817
[task 2021-08-04T15:13:52.808Z] 15:13:52     INFO -  Notified in 7235 msec <<<< kNotificationTimeoutMs needs to be bigger than this
[task 2021-08-04T15:13:52.808Z] 15:13:52     INFO -  Done in 0 msec
[task 2021-08-04T15:14:04.048Z] 15:14:04     INFO -  Done in 11234 msec <<<< kStateChangeTimeoutMs needs to be bigger than this
[task 2021-08-04T15:14:04.109Z] 15:14:04     INFO -  TEST-PASS | AvailableMemoryWatcherFixture.AlwaysActive | test completed (time: 18530ms)

The log above shows the original thresholds 5000 and 10000 were insufficient for ASan build.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3be9b5df5544
Increase the timeout thresholds in AvailableMemoryWatcherFixture.  r=gsvelto

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3be9b5df5544