Closed
Bug 1722453
Opened 4 years ago
Closed 4 years ago
Remove remaining private slot uses outside the JS engine
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
92 Branch
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(5 files)
|
Bug 1722453 part 1 - Use a reserved slot instead of private slot for CTypes CDataFinalizer. r?jonco!
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
After we stop using private slots outside the JS engine, we can remove JS::SetPrivate and make private slots only usable inside the JS engine.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D120936
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D120937
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D120938
|
|
Assignee | |
Comment 5•4 years ago
|
||
This will help prevent new uses.
Depends on D120939
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8cb6499a37b
part 1 - Use a reserved slot instead of private slot for CTypes CDataFinalizer. r=jonco
https://hg.mozilla.org/integration/autoland/rev/385f462e70b9
part 2 - Use a reserved slot instead of private slot for telemetry histogram objects. r=jonco,mccr8
https://hg.mozilla.org/integration/autoland/rev/21a34ba39e98
part 3 - Use a reserved slot instead of private slot for XPCWrappedNativeProto. r=jonco,mccr8
https://hg.mozilla.org/integration/autoland/rev/c7bbd484becf
part 4 - Use a reserved slot instead of private slot for XPCWrappedNativeTearOff. r=jonco,mccr8
https://hg.mozilla.org/integration/autoland/rev/55840ec461aa
part 5 - Remove some APIs for private slots. r=jonco
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a8cb6499a37b
https://hg.mozilla.org/mozilla-central/rev/385f462e70b9
https://hg.mozilla.org/mozilla-central/rev/21a34ba39e98
https://hg.mozilla.org/mozilla-central/rev/c7bbd484becf
https://hg.mozilla.org/mozilla-central/rev/55840ec461aa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•