Closed Bug 1722462 Opened 3 years ago Closed 3 years ago

browser_device_change.js (and many other RDM tests) fail with server targets

Categories

(DevTools :: Responsive Design Mode, defect)

defect

Tracking

(Fission Milestone:MVP, firefox92 fixed)

RESOLVED FIXED
92 Branch
Fission Milestone MVP
Tracking Status
firefox92 --- fixed

People

(Reporter: ochameau, Assigned: nchevobbe)

References

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file, 1 obsolete file)

This fails because we are closing the RDM over here:
https://searchfox.org/mozilla-central/rev/072710086ddfe25aa2962c8399fefb2304e8193b/devtools/client/responsive/test/browser/browser_device_change.js#110-112
And expect it to reload the page. We then assert values which depends on reloading the page.
But we don't reload with server targets, because over there:
https://searchfox.org/mozilla-central/rev/072710086ddfe25aa2962c8399fefb2304e8193b/devtools/client/responsive/ui.js#252-259
this.responsiveFront is destroyed...

I imagine that during a target switch, when doing a reload this front may be destroyed during a short period of time.
We should probably change this check to something else.

This test expect RDM to reload the page on destroy,
but because of a race condition -or- because of a behavior change with target switching,
responsiveFront ends up being destroyed and we don't reload.

(And may be also browser_max_touchpoints.js, browser_page_redirection.js, browser_touch_event_should_bubble.js, /browser_touch_pointerevents.js, ...)

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1b816e832bb [devtools] Wait for dom-complete in waitForViewportLoad. r=ochameau
Whiteboard: dt-fission-future
Fission Milestone: --- → MVP
Whiteboard: dt-fission-future → dt-fission-m3-mvp
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Attachment #9233299 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: