1722472 - Dark Theme color problem for event description

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[adrien.rybarczyk]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

1. Be in dark theme or in system theme with dark application mode.
2. Create an event and put a description.

Actual results:

The color of the description text is not adapted according to the theme for the first edition of the description.

If we save and reopen the event, the text color will be adapted according to the theme.

Expected results:

The color of the description text is at all times adapted to the theme.

Comment 1

[adrien.rybarczyk]

Attachment: firstUpdateDescription.PNG

Comment 2

[adrien.rybarczyk]

Attachment: secondUpdateDescription.PNG

Comment 3

[adrien.rybarczyk]

The problem did not exist in 78. This seems to be due to the change of the textarea for an editor.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1722472-load-EditorContent.css.patch

The stylesheet was only loaded when there was a existing description. I moved it out of the if (aItem.descriptionText) {}.

Is this okay like this?

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9233309 [details] [diff] [review]
1722472-load-EditorContent.css.patch

That triggers the save prompt even if no modifications are made. I moved editor.resetModificationCount(); below the conditional block and that seems to work.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1722472-load-EditorContent.css.patch

(In reply to Geoff Lankow (:darktrojan) from comment #5)

Comment on attachment 9233309 [details] [diff] [review]
1722472-load-EditorContent.css.patch

That triggers the save prompt even if no modifications are made. I moved editor.resetModificationCount(); below the conditional block and that seems to work.

Like this?

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9233470 [details] [diff] [review]
1722472-load-EditorContent.css.patch

Like this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3be537f2b12f
Load EditorContent.css always into the event description. r=darktrojan

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9233470 [details] [diff] [review]
1722472-load-EditorContent.css.patch

[Approval Request Comment]
User impact if declined: with dark theme opening a new event the description isn't readable
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9233470 [details] [diff] [review]
1722472-load-EditorContent.css.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/0a12973eabe9

Comment 12

[WaltS48 [:walts48]]

Verified using TB 91.0b5 on Fedora 34 Workstation, Gnome desktop.