1722476 - browser_dbg-link-reload.js fails with server targets

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Alexandre Poirot [:ochameau]]

This seem to be just a race condition which should already exist in the test.
Not clear why it wasn't happening before?
https://searchfox.org/mozilla-central/source/devtools/client/debugger/test/mochitest/browser_dbg-link-reload.js

  const dbg = await initDebugger("doc-reload-link.html");
  const {
    selectors: { getSelectedSource, getIsPaused, getCurrentThread },
    getState
  } = dbg;
 
  info("Add a breakpoint that will be hit on reload");
  await addBreakpoint(dbg, "doc-reload-link.html", 3);

initDebugger wasn't waiting for any source to be loaded (it doesn't wait for the url to be loaded as source and require more arguments)
This was leading to addBreakpoint to throw because doc-reload-link.html wasn't always already loaded.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1722476 - [devtools] Fix browser_dbg-link-reload.js with server side target.

We weren't waiting for the html page to be displayed in the source tree,
leading to failure when trying to set the breakpoint just after opening the toolbox.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/325375c2d4cf
[devtools] Fix browser_dbg-link-reload.js with server side target. r=nchevobbe

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/325375c2d4cf