1722489 - Evaluate HSTS before https-only in NS_ShouldSecureUpgrade

Status: RESOLVED FIXED

(Core :: Networking, task, P1)

Description

[Tomer Yavor]

We need to swap some lines to proccess hsts request correctly in case https-only mode is enabled. So that bug is to build the basis for an upcoming patch of https-only mode.

Comment 1

[Tomer Yavor]

Attachment: Bug 1722489 - Evaluate HSTS before https-only in NS_ShouldSecureUpgrade. r=ckerschb

Comment 2

[Tomer Yavor]

Attachment: Bug 1722489 - Evaluate HSTS before https-only in NS_ShouldSecureUpgrade. r=ckerschb

Comment 3

[Tomer Yavor]

Attachment: Bug 1722489 - Evaluate HSTS before https-only in NS_ShouldSecureUpgrade. r=ckerschb

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbffee5cbf0d
Evaluate HSTS before https-only in NS_ShouldSecureUpgrade. r=ckerschb,necko-reviewers,kershaw

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_iframe_test.js

• backout: https://hg.mozilla.org/integration/autoland/rev/ab662429ef83754539b076eacfe20a04f06696dd

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=dbffee5cbf0dd84a9952b6a84059b3689bca9bee

• push where failures appeared due to busted builds in original push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=SuiJt237RhaqoqIOyeetaA.0&revision=0c7c6ed0e63b3edd49cc49bff80845d65acfc8a6

• failure log: https://treeherder.mozilla.org/logviewer?job_id=353761980&repo=autoland&lineNumber=39723

[task 2021-10-05T21:16:38.076Z] 21:16:38     INFO - Console message: [JavaScript Error: "Blocked loading mixed active content http://example.com/browser/dom/security/test/https-only/file_iframe_test.sjs?com-test1.1" {file: "https://example.com/browser/dom/security/test/https-only/file_iframe_test.sjs?test1.1" line: 0}]
[task 2021-10-05T21:16:38.077Z] 21:16:38     INFO - Console message: [JavaScript Error: "Blocked loading mixed active content http://example.org/browser/dom/security/test/https-only/file_iframe_test.sjs?org-test1.1" {file: "https://example.com/browser/dom/security/test/https-only/file_iframe_test.sjs?test1.1" line: 0}]
[task 2021-10-05T21:16:38.077Z] 21:16:38     INFO - Buffered messages logged at 21:15:15
[task 2021-10-05T21:16:38.078Z] 21:16:38     INFO - Console message: [JavaScript Warning: "telemetry.state_file_read_errors - Unknown scalar."]
[task 2021-10-05T21:16:38.078Z] 21:16:38     INFO - Console message: [JavaScript Warning: "telemetry.generated_new_client_id - Unknown scalar."]
[task 2021-10-05T21:16:38.078Z] 21:16:38     INFO - Buffered messages finished
[task 2021-10-05T21:16:38.079Z] 21:16:38     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/https-only/browser_iframe_test.js | Test timed out - 
[task 2021-10-05T21:16:38.079Z] 21:16:38     INFO - GECKO(688) | MEMORY STAT | vsize 2104199MB | vsizeMaxContiguous 65449867MB | residentFast 257MB | heapAllocated 85MB
[task 2021-10-05T21:16:38.080Z] 21:16:38     INFO - TEST-OK | dom/security/test/https-only/browser_iframe_test.js | took 90033ms
[task 2021-10-05T21:16:38.080Z] 21:16:38     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-10-05T21:16:38.081Z] 21:16:38     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/https-only/browser_iframe_test.js | Found a tab after previous test timed out: https://example.com/browser/dom/security/test/https-only/file_iframe_test.sjs?test1.1 - 
[task 2021-10-05T21:16:38.082Z] 21:16:38     INFO - GECKO(688) | [Child 8444: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 2127f447400 == 2 [pid = 8444] [id = 5] [url = about:blank]
[task 2021-10-05T21:16:38.082Z] 21:16:38     INFO - GECKO(688) | [Child 8444: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 2127f448c00 == 1 [pid = 8444] [id = 6] [url = about:blank]
[task 2021-10-05T21:16:38.082Z] 21:16:38     INFO - GECKO(688) | [Child 6540: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 1fe04eb2c00 == 1 [pid = 6540] [id = 1]
[task 2021-10-05T21:16:38.083Z] 21:16:38     INFO - GECKO(688) | [Child 6540: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (1fe04ec23c0) [pid = 6540] [serial = 5] [outer = 0]
[task 2021-10-05T21:16:38.084Z] 21:16:38     INFO - GECKO(688) | [Child 6540: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (1fe04eb8c00) [pid = 6540] [serial = 6] [outer = 1fe04ec23c0]
[task 2021-10-05T21:16:38.091Z] 21:16:38     INFO - checking window state

Comment 6

[Natalia Csoregi [:nataliaCs]]

Other failure: TEST-UNEXPECTED-FAIL | dom/security/test/https-only/browser_hsts_host.js | uncaught exception - TypeError: can't access property "description", tests[0] is undefined at on_new_message@chrome://mochitests/content/browser/dom/security/test/https-only/browser_hsts_host.js:85:5

Comment 7

[Tomer Yavor]

I will fix it

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c01c20b5f176
Evaluate HSTS before https-only in NS_ShouldSecureUpgrade. r=ckerschb,necko-reviewers,kershaw

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c01c20b5f176