1722507 - Search bar displays cut off search engine at the bottom

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: search_image

Affected versions

• 92.0a1 (20210727094543)
• 91.0b7 (20210725190237)

Affected platforms

• Windows 10x64
• Windows 7x64

Steps to reproduce

1. Unfortunately I don’t have some STR for this issue but I attached a profile on which the issue is reproducible (link to profile).

Expected result

• Address bar is displayed as expected.

Actual result

• Address bar displayed cut-off engine.

Regression range

• Mozregression pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3e2960113395aeb43cfdb56fc74da7debd6b204b&tochange=a5c85f93707c2790de3cceeda5155bb29d371909

Notes

• Attached a screenshot.
• Cannot reproduce the issue on macOS 10.15 using the attached profile.

Comment 1

[Julien Cristau [:jcristau] (back April 22)]

Can you take a look?

Comment 2

[Daisuke Akatsuka (:daisuke)]

Thank you very much!
But, I could not reproduce this issue yet...

Alexandru,
I imagined that this profile would have made the search bar visible and changed the engine to DDG, but it seemed to be the same as the default settings. This might be a different profile?? If possible, could you send the profile again?

Thanks!
Daisuke

Comment 3

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: x2lokk75.76o7p.zip

(In reply to Daisuke Akatsuka (:daisuke) from comment #2)

Thank you very much!
But, I could not reproduce this issue yet...

Alexandru,
I imagined that this profile would have made the search bar visible and changed the engine to DDG, but it seemed to be the same as the default settings. This might be a different profile?? If possible, could you send the profile again?

Thanks!
Daisuke

Oh sorry for that :(. I have managed to make another one. I hope that this is working as expected. Vaguely the steps where:

1. Add Search bar between overflow arrow and Sync icon (while in customize) and then change search engine to DDG.
2. Resize Fx with search bar opened until search engines are on two rows.
3. Enter and exit Fullscreen while the search bar is opened. This needs some tries and resizing to happen.
   But I cannot repro every time. If more investigation is needed please let me know. Thank you!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Alexandru!
I could reproduce it. I will take a look at this issue.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1722507: Get rid of extra margin to calculate the height of container correctly.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1722507: Get rid of extra spacer.

Depends on D122300

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4047f212ac51
Get rid of extra margin to calculate the height of container correctly. r=desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/8a9517eb8c59
Get rid of extra spacer. r=desktop-theme-reviewers,harry

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4047f212ac51
https://hg.mozilla.org/mozilla-central/rev/8a9517eb8c59

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 93.0a1 (20210816094534) on Windows 10x64 and attached profile from comment 3. Search engines ar no longer cut when using the profile or when following STR from comment 3.

Comment 11

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9235708 [details]
Bug 1722507: Get rid of extra margin to calculate the height of container correctly.

Beta/Release Uplift Approval Request

• User impact if declined: Style of search engine buttons will be broken a bit.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Main change is only a style and it is one line.
  And also, we got rid of unused code.
• String changes made/needed:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235708 [details]
Bug 1722507: Get rid of extra margin to calculate the height of container correctly.

Approved for 92.0b5.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235708 [details]
Bug 1722507: Get rid of extra margin to calculate the height of container correctly.

And 91.1esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d3e4d26fd86a
https://hg.mozilla.org/releases/mozilla-beta/rev/b2b77609bf7c

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/58881c0c4066
https://hg.mozilla.org/releases/mozilla-esr91/rev/7c78088d9e79

Comment 16

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 92.0b5 and Firefox 91.1.1esr (20210817212725) from comment 15 on Windows 10x64 using the attached profile from comment 3.