1722543 - browser_dbg-windowless-service-workers.js fails with server targets

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Alexandre Poirot [:ochameau]]

The test timesout of this line:
https://searchfox.org/mozilla-central/rev/072710086ddfe25aa2962c8399fefb2304e8193b/devtools/client/debugger/test/mochitest/browser_dbg-windowless-service-workers.js#49

 await waitForPaused(dbg);

For some reason, the debugger no longer pause in the SW on reload. Or at least the frontend doesn't report the pause.

Given that this feature is preffed off, we could consider forcing server target to false in this test in order to toggle the server target sooner than later.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The script itself seems to pause okay, but we don't get the information.
From some logging, it looks like the paused event that is sent from the actor is not received by the associated front / the THREAD_STATE legacy listener
attachAndInitThread is called after the event is emitted which probably explain this issue.
I'm trying to see how this could be fixed

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1722543 - [devtools] Don't actually destroy service worker targets on target switching. r=jdescottes.

This makes browser_dbg-windowless-service-workers.js pass
with server side target switching.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96d1e40298c0
[devtools] Don't actually destroy service worker targets on target switching. r=jdescottes.

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/96d1e40298c0