1722554 - aarch64-linux is broken in third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect, P5)

Description

[tt_1]

Attachment: build.log.gz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

I compiled recent git for aarch64-linux

Actual results:

the build fails to compile with this error:

25:59.72 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:158:54: error: cannot convert 'int16x8_t' to 'uint8x16_t'
25:59.73 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:163:54: error: cannot convert 'int16x8_t' to 'uint8x16_t'
25:59.74 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:166:30: error: cannot convert 'uint8x16_t' to 'int16x8_t'
25:59.76 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:166:61: error: cannot convert 'uint8x16_t' to 'int16x8_t'
25:59.77 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:291:29: error: cannot convert '__Int16x8_t' to 'uint16x8_t' in initialization
25:59.79 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:292:29: error: cannot convert '__Int16x8_t' to 'uint16x8_t' in initialization
25:59.80 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:293:29: error: cannot convert '__Int16x8_t' to 'uint16x8_t' in initialization
25:59.80 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:296:61: error: cannot convert 'uint16x8_t' to 'int16x8_t'
25:59.81 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:298:61: error: cannot convert 'uint16x8_t' to 'int16x8_t'
25:59.83 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:300:61: error: cannot convert 'uint16x8_t' to 'int16x8_t'
26:01.25 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:158:54: error: cannot convert 'int16x8_t' to 'uint8x16_t'
26:01.26 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:163:54: error: cannot convert 'int16x8_t' to 'uint8x16_t'
26:01.27 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:166:30: error: cannot convert 'uint8x16_t' to 'int16x8_t'
26:01.28 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:166:61: error: cannot convert 'uint8x16_t' to 'int16x8_t'
26:01.30 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:291:29: error: cannot convert '__Int16x8_t' to 'uint16x8_t' in initialization
26:01.30 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:292:29: error: cannot convert '__Int16x8_t' to 'uint16x8_t' in initialization
26:01.32 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:293:29: error: cannot convert '__Int16x8_t' to 'uint16x8_t' in initialization
26:01.32 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:296:61: error: cannot convert 'uint16x8_t' to 'int16x8_t'
26:01.33 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:298:61: error: cannot convert 'uint16x8_t' to 'int16x8_t'
26:01.35 /usr/aarch64-unknown-linux-gnu/tmp/portage/www-client/firefox-92.0/work/firefox-92.0/third_party/jpeg-xl/lib/jxl/dec_xyb-inl.h:300:61: error: cannot convert 'uint16x8_t' to 'int16x8_t'

Expected results:

I expect the build to pass

compressed log is attached, will explain in a seperate posting

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::ImageLib' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[tt_1]

this has been reported by another user and fixed upstream in https://github.com/libjxl/libjxl/commit/05707452c8fac2b7afdd2d2f88ce3613b614750c (issue: https://github.com/libjxl/libjxl/issues/64) , pulling in the patch on top of the in tree copy is enough to fix the compile error. It might be a better idea to pull in a more recent copy of jxl itself to fix this, instead of cherry picking.

--disable-jxl is also a possible workaround

Comment 3

[tt_1]

So, there are three or four bugs open at the moment to update jpeg-xl to a version that has the fix included, but non ever got merged unless I'm misstaken. Can you maybe check why the update hasn't been pushed into the tree? Thanks.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Sorry, will take a look soon-ish. Keeping NI.

Comment 5

[tt_1]

its fixed in aarch64-linux, thank you

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Great, thank you for the update!