1722567 - Multiple tabs undo close not consistent

Status: REOPENED

(Firefox :: Tabbed Browser, defect)

Description

[Antonin LOUBIERE]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Open some tabs
Close 4 tabs (grouped)
Close 1 tab
Reopen closed tabs

Actual results:

The last 4 tabs reopen.
Do "reopen closed tabs" to reopen the first tab.

Expected results:

The last tab should be restored alone, then if "reopen closed tabs" is do again, it should restore all 4 tabs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alin Ilea, Desktop QA]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Hi,

I am able to reproduce the issue in release 90.0.2, beta 91.0b7 and latest nightly 92.0a1 (2021-07-28) using Windows 10.

Thanks for your input.

Comment 3

[Antonin LOUBIERE]

Attachment: Bug 1722567 - Save group of closed tabs to restore the all group. r=kashav

When a group of tabs is closed, save the it in session data so tabs could be restored together.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aaaf18f2aae
Save group of closed tabs to restore the all group. r=kashav

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset 6aaaf18f2aae (Bug 1722567) for causing bc failures in browser_forget_async_closings.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/943a0020922197ac932b3f1823f5f4299970ae87
Push with failures, failure log.

Comment 6

[Antonin LOUBIERE]

Thanks I will investigate.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b911ae170ab6
Save group of closed tabs to restore the all group. r=kashav

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3926e1cff232
Backed out changeset b911ae170ab6 for causing failures on browser_frame_history.js. CLOSED TREE

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures on browser_frame_history.js. CLOSED TREE
Link to backout : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=3926e1cff232430b756608c309924dd2d6725289
Link to push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=b911ae170ab6be7f683e7433915df6f23f19ebf4&selectedTaskRun=HqAgXTHUQK2s2RSK8mHLIQ.0
Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=349614403&repo=autoland&lineNumber=3810

Comment 10

[Antonin LOUBIERE]

Thanks I will investigate.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06634a58a08a
Save group of closed tabs to restore the all group. r=kashav

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/06634a58a08a

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 14

[Monica Chiorean]

I was able to reproduce the issue on release 90.0.2.

On latest Beta 94.0b2 and Nightly 95.0a1 on Win10&Ubuntu20.4 issue is partially fixed, meaning:

1. Close 4tabs and than 1tab.

2. Press to reopen closed tab first time:
   Actual/Expected result: Only one tab is reopened.

3. Press to reopen closed tab second time:
   Actual result: Only one tab is reopened.
   Expected result: All 4 tabs previously closed should be opened.

Reopen issue based on about description.

Comment 15

[Antonin LOUBIERE]

Yes, you are right, but in phabricator we decided to not do this part and only handle the last group closed, so it's fixes the inconsistent part and will either reopen an exact group of tabs or if it was a group but other tabs were closed after, it will reopen tabs one by one. What should we do with this bug, should we keep it open or should we close it?

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.