1722575 - browser_inspector_inspect_node_contextmenu_nested.js fails with server targets

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect)

Description

[Alexandre Poirot [:ochameau]]

The test fails with:

devtools/client/inspector/test/browser_inspector_inspect_node_contextmenu_nested.js
  FAIL The correct node is selected in the markup view - Got null, expected "in-same_process_frame"
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:1371
chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_inspect_node_contextmenu_nested.js:checkSelectedNode:111
chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_inspect_node_contextmenu_nested.js:null:84
chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
chrome://mochikit/content/browser-test.js:Tester_execTest:1138
chrome://mochikit/content/browser-test.js:nextTest/<:946
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1041

This doesn't look like a race condition in the test, I tried adding a few additional wait without fixing this.

Could it be something wrong with this code?
https://searchfox.org/mozilla-central/rev/072710086ddfe25aa2962c8399fefb2304e8193b/devtools/client/inspector/test/browser_inspector_inspect_node_contextmenu_nested.js#146

  await gContextMenu.inspectNode();

Which ends up calling this code?
https://searchfox.org/mozilla-central/rev/072710086ddfe25aa2962c8399fefb2304e8193b/devtools/client/framework/devtools.js#749-776

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I can't reproduce even with --verify, with and without fission.
Let's keep this open for now until we can confirm with TRY

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I'm not seeing this in my TRY pushes either, let's close it :)