1722576 - Implement self.structuredClone()

Status: RESOLVED FIXED

(Core :: DOM: postMessage, enhancement)

Description

[Domenic Denicola]

Spec PR: https://github.com/whatwg/html/pull/3414
Tests PR: https://github.com/web-platform-tests/wpt/pull/11069
Spec: https://html.spec.whatwg.org/#structured-cloning

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1722576 - Implement self.structuredClone(). r?baku,sfink

Comment 2

[Tom S [:evilpie]]

Steve, I was hoping you could take a look at this. Thanks.

Comment 3

[Tom S [:evilpie]]

Attachment: Bug 1722576 - Rename PostMessageOptions to StructuredSerializeOptions. r?baku

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d0e3d6a1960
Implement self.structuredClone(). r=smaug,sfink,baku
https://hg.mozilla.org/integration/autoland/rev/d31a1c199922
Rename PostMessageOptions to StructuredSerializeOptions. r=smaug

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in structured-clone.any.worker.html

Backout link

Push with failures

Failure log

Comment 6

[Tom S [:evilpie]]

The destructor has an assertion for mTransferredPorts.IsEmpty(). As far as I can tell we aren't supposed to do anything with the transferred ports, so we can just work around that assertion.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f50502328881
Implement self.structuredClone(). r=smaug,sfink,baku
https://hg.mozilla.org/integration/autoland/rev/b486e4108902
Rename PostMessageOptions to StructuredSerializeOptions. r=smaug

Comment 8

[Tom S [:evilpie]]

Attachment: Bug 1722576 - Fix clang-tidy build error

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa67c5a8e93c
Fix clang-tidy build error

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f50502328881
https://hg.mozilla.org/mozilla-central/rev/b486e4108902
https://hg.mozilla.org/mozilla-central/rev/aa67c5a8e93c

Comment 11

[Andreu Botella]

Hey, it's great to see structuredClone() land in Firefox!

For the record, the failing WPT tests in html/webappapis/structured-clone/structured-clone.any.html are due to a bug I introduced in https://github.com/web-platform-tests/wpt/pull/30824, which was specific to the self.structuredClone() runner and worked fine with other uses of the structured clone algorithm. This is now being fixed in https://github.com/web-platform-tests/wpt/pull/31034.