1722588 - Disabled menus aren't shown as disabled

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Richard Marti (:Paenglab)]

Good visible with TB's composer there Insert and Format should be disabled when opening. Now there is no difference to the active menus.

Regressed by bug 1710643 by https://searchfox.org/mozilla-central/rev/072710086ddfe25aa2962c8399fefb2304e8193b/toolkit/themes/linux/global/menu.css#66 which has precedence to https://searchfox.org/mozilla-central/rev/072710086ddfe25aa2962c8399fefb2304e8193b/toolkit/themes/linux/global/menu.css#48

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1722588 - Reintroduce the :not([disabled="true"]) check for menu. r=Gijs

Comment 2

[Richard Marti (:Paenglab)]

[Tracking Requested - why for this release]: bug 1710643 landed on 90 and 91 as base of ESR should get this fix.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5aec083e0062
Reintroduce the :not([disabled="true"]) check for menu. r=Gijs,emilio

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5aec083e0062

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9233370 [details]
Bug 1722588 - Reintroduce the :not([disabled="true"]) check for menu. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: On Linux no differentiation between active and disabled menus.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: The issue is only visible in Thunderbird.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a simple CSS change that adds a previously removed selector back.
• String changes made/needed: no

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9233370 [details]
Bug 1722588 - Reintroduce the :not([disabled="true"]) check for menu. r=Gijs

Approved for 91 beta 9, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/319d0f97eed0