Closed
Bug 1722664
Opened 4 years ago
Closed 4 years ago
browser_net_error-boundary-01.js fails intermittently with server targets
Categories
(DevTools :: Netmonitor, defect)
DevTools
Netmonitor
Tracking
(Fission Milestone:MVP, firefox92 fixed)
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
This fails because the test tries to access to TargetMixin.localTab during toolbox destroy, while this can throw:
https://searchfox.org/mozilla-central/rev/a9db89754fb507254cb8422e5a00af7c10d98264/devtools/client/fronts/targets/target-mixin.js#114-116
|
Assignee | |
Comment 1•4 years ago
|
||
Accessing TargetMixin.localTab during destroy is risky as it may throw.
Reading TabDescriptor.localTab is safer as it will never throw.
This test was failing intermittently on debug builds.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/137df1321753
[devtools] Fix browser_net_error-boundary-01.js intermittent with server targets. r=nchevobbe
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
|
||
Updated•4 years ago
|
Fission Milestone: --- → MVP
Whiteboard: dt-fission-m3-mvp
You need to log in
before you can comment on or make changes to this bug.
Description
•