1722668 - Speed up temporary storage initialization by removing old origin directories

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P1)

Description

[Jan Varga [:janv]]

Some users have a lot of free space on disk so origins are never evicted which leads to large set of directories and files after some time (years). This can be a problem on slower hardware, so we should reduce number of origin directories if the initialization takes longer than X seconds. Origins which were used in last 13 months shouldn't be removed.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1722668 - Speed up temporary storage initialization by archiving unaccessed origin directories; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1722668 - Implement a workaround for the case when GetLastModifiedTime returns INT64_MIN; r=#dom-storage

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1722668 - Expose nsFileStream via the component manager; r=#dom-storage

Depends on D123613

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7179b67eb1a
Implement a workaround for the case when GetLastModifiedTime returns INT64_MIN; r=jari
https://hg.mozilla.org/integration/autoland/rev/c9f100cb3f86
Expose nsFileStream via the component manager; r=necko-reviewers,dragana,jari
https://hg.mozilla.org/integration/autoland/rev/db05822c64ff
Speed up temporary storage initialization by archiving unaccessed origin directories; r=jari

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_unsetLastAccessTime.js

• backout: https://hg.mozilla.org/integration/autoland/rev/1546185c8149b2e5ebb3eae1bc293de0aca41632

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=db05822c64ff334cae9338ec25fa0874beb35be6&group_state=expanded

• failure log: https://treeherder.mozilla.org/logviewer?job_id=350567091&repo=autoland&lineNumber=5084

[task 2021-09-04T21:08:20.666Z] 21:08:20     INFO -  TEST-START | dom/quota/test/xpcshell/test_unsetLastAccessTime.js
[task 2021-09-04T21:08:20.937Z] 21:08:20  WARNING -  TEST-UNEXPECTED-FAIL | dom/quota/test/xpcshell/test_unsetLastAccessTime.js | xpcshell return code: 0
[task 2021-09-04T21:08:20.937Z] 21:08:20     INFO -  TEST-INFO took 270ms
[task 2021-09-04T21:08:20.937Z] 21:08:20     INFO -  >>>>>>>
[task 2021-09-04T21:08:20.937Z] 21:08:20     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-09-04T21:08:20.938Z] 21:08:20     INFO -  TEST-PASS | dom/quota/test/xpcshell/test_unsetLastAccessTime.js | undefined assertion name - There should be a testSteps function - true == true

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48e005ee27b7
Implement a workaround for the case when GetLastModifiedTime returns INT64_MIN; r=jari
https://hg.mozilla.org/integration/autoland/rev/126032a9c310
Expose nsFileStream via the component manager; r=necko-reviewers,dragana,jari
https://hg.mozilla.org/integration/autoland/rev/144d07c1d155
Speed up temporary storage initialization by archiving unaccessed origin directories; r=jari

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/48e005ee27b7
https://hg.mozilla.org/mozilla-central/rev/126032a9c310
https://hg.mozilla.org/mozilla-central/rev/144d07c1d155

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1722668 - Implement nsIQuotaManagerService::getFullOriginMetadata; r=#dom-storage

Comment 9

[Jan Varga [:janv]]

Attachment: Bug 1722668 - Add test_unsetLastAccessTime.js for the case when quota information is cached; r=#dom-storage

Depends on D125168

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af59d0fac304
Implement nsIQuotaManagerService::getFullOriginMetadata; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/0d3c7f057415
Add test_unsetLastAccessTime.js for the case when quota information is cached; r=dom-storage-reviewers,jari

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/578556238bcb
Fix lint failure r=fix

Comment 12

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/af59d0fac304
https://hg.mozilla.org/mozilla-central/rev/0d3c7f057415
https://hg.mozilla.org/mozilla-central/rev/578556238bcb