1722700 - [Wayland] Drag and drop alternates between working and not working when switching application focus

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Kestrel]

STR:

1. Start with MOZ_ENABLE_WAYLAND=1 on Ubuntu 21.04.
2. Attempt to drag a tab to a different position.
3. Alt+Tab to a different application, then back again.
4. Attempt to drag a tab to a different position.
5. Repeat.

Dragging does not work alternately when app focus is changed.

Does not occur with x11/xwayland.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=da1412413022e9f41073122b340e6f8d79091bb9&tochange=35d406f57982d5cf0a8d3f73421903d99c49ca8b

Regressed by Bug 1717476.

Comment 1

[Viktor Jägersküpper]

For me it doesn't work at all after bug 1717476, switching apps doesn't change anything, but I'm on Arch Linux. No idea what makes the difference or if I'm too stupid to do it correctly.

Also customizing the toolbar via drag-and-drop doesn't work after bug 1717476: I can drag an icon, but I can't drop it to another position in the toolbar or remove it from the toolbar, and I can't add an icon either. Martin, do you want me to file another bug for that or can both issues be dealt with in this bug?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I'll look at it this week.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Guys, which compositor / DE do you run?
Thanks.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

I can reproduce the D&D failure on tab strip.

Comment 5

[Viktor Jägersküpper]

I'm running Gnome Shell 40.3 with Mutter 40.3.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1722700 [Wayland] Merge WaylandDragAndDropDataOffer and DataOffer classes, r?rmader

Merge WaylandDragAndDropDataOffer and DataOffer classes to avoid potential timing issue when Drag&Drop action is set before WaylandDragAndDropDataOffer is created.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f51d18d39f0f
[Wayland] Merge WaylandDragAndDropDataOffer and DataOffer classes, r=rmader

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f51d18d39f0f