Closed
Bug 1722725
Opened 3 years ago
Closed 3 years ago
Benign race in AsyncPanZoomController::SetTestAsyncScrollOffset
Categories
(Core :: Panning and Zooming, defect, P3)
Tracking
()
RESOLVED
FIXED
92 Branch
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-esr91+
|
Details | Review |
This was triggered in the tsan builds. I think it is just used by tests and just needs an existing mutex to cover it.
|
Assignee | |
Comment 1•3 years ago
|
||
This got tripped in the tsan tests, but should only happen during
testing.
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5878ca886c5
Fix benign race in AsyncPanZoomController::SetTestAsyncScrollOffset. r=gfx-reviewers,jrmuizel
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
|
||
Updated•3 years ago
|
Component: Graphics: WebRender → Panning and Zooming
|
||
Comment 4•3 years ago
|
||
Comment on attachment 9233515 [details]
Bug 1722725 - Fix benign race in AsyncPanZoomController::SetTestAsyncScrollOffset.
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: The race sometimes causes TSan failures on mozilla-esr91 CI runs, e.g. bug 1724318
- User impact if declined: N/A
- Fix Landed on Version:
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): test-only codepath
- String or UUID changes made by this patch:
Attachment #9233515 -
Flags: approval-mozilla-esr91?
|
||
Comment 6•3 years ago
|
||
Comment on attachment 9233515 [details]
Bug 1722725 - Fix benign race in AsyncPanZoomController::SetTestAsyncScrollOffset.
approved for 91.1esr
Attachment #9233515 -
Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
|
|
||
Comment 7•3 years ago
|
||
| bugherder uplift | ||
status-firefox-esr91:
--- → fixed
|
||
Comment 8•3 years ago
|
||
Is there a suppression which should be removed with this patch landed?
Flags: needinfo?(aosmond)
|
|
Assignee | |
Comment 9•3 years ago
|
||
No, I fixed it in advance before turning on some tests it would have tripped on.
Flags: needinfo?(aosmond)
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•