1722749 - browser_ext_devtools_inspectedWindow_targetSwitch.js fails with server targets

Status: RESOLVED FIXED

(WebExtensions :: Developer Tools, defect)

Description

[Alexandre Poirot [:ochameau]]

$ ./mach mochitest --headless browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow_targetSwitch.js

This test fails for various reason, but the one I'm trying to fix is the fact that it does reload too quickly.
The test is listening for the target-switched on the toolbox's commands:
https://searchfox.org/mozilla-central/rev/a9db89754fb507254cb8422e5a00af7c10d98264/browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow_targetSwitch.js#31-33

  const onSwitched = toolbox.commands.targetCommand.once("switched-target");
  BrowserTestUtils.loadURI(tab.linkedBrowser, uri);
  await onSwitched;

Whereas it should also or instead listen for target to be switched on the distinct commands used by WebExt codebase. The one which does the reload:
https://searchfox.org/mozilla-central/source/browser/components/extensions/parent/ext-devtools-inspectedWindow.js#42-48

            const commands = await context.getDevToolsCommands();
            commands.inspectedWindowCommand.reload(callerInfo, {
              ignoreCache,
              userAgent,
              injectedScript,
            });

Another angle to tackle that would be to have the devtools.inspectedWindow.reload to either return a promise which would resolve only once reloaded ? Or have it to emit an event which the test can listen to.
Because clearly, the test isn't waiting for the full reload of the page before proceeding with the next.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1722749 - [devtools] Fix browser_ext_devtools_inspectedWindow_targetSwitch.js with server targets.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f21ddd4afe0e
[devtools] Fix browser_ext_devtools_inspectedWindow_targetSwitch.js with server targets. r=rpl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aff2ad98df1
fix eslint failures. a=lint-fix CLOSED TREE

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f21ddd4afe0e
https://hg.mozilla.org/mozilla-central/rev/4aff2ad98df1