1722801 - test_webconsole-node-grip.html fails with server targets

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Alexandre Poirot [:ochameau]]

This test fails for a surprising reason. See more info on phabricator.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1722801 - [devtools] Fix devtools/server/tests/chrome/test_webconsole-node-grip.html

I can't explain how we end up with a null connection in _connections,
_connectionClosed is called for the failing connID and delete should
be removing the entry... and not nullifying it.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1722801 - [devtools] Get all connections before closing them in DevToolsServer.destroy. r=jdescottes.

When running test_webconsole-node-grip.html with server side target switching,
the test was failing as accessing this._connections[connID] was returning a
null object.
From some quick investigation, it looks like the object was nullified after
a first connection was closed.
Retrieving all the connection objects before looping closing them seems to
fix the issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a1258e10d17
[devtools] Get all connections before closing them in DevToolsServer.destroy. r=jdescottes.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4a1258e10d17