1722817 - AMO Extension validator uses the outdated rules

Status: RESOLVED MOVED

(WebExtensions :: Untriaged, defect)

Description

[Akoki]

Attachment: demo.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4495.0 Safari/537.36

Steps to reproduce:

Try to submit the attached extension to addons.mozilla.org

Actual results:

The extension is successfully accepted.

Expected results:

The extension is rejected:
JavaScript syntax error (Parsing as module error: Unexpected token = at line: 3 and column: 17) (Parsing as script error: Unexpected token = at line: 3 and column: 17)
JavaScript syntax error (Parsing as module error: Unexpected token = at line: 4 and column: 17) (Parsing as script error: 'import' and 'export' may appear only with 'sourceType: module' at line: 1 and column: 1)

The validator can't work with ES6 imports and with class static properties.

While the extension works fine even in Firefox ESR (78) (the actual Firefox version is 90).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Akoki]

"Actual results:" confused with "Expected results:".

Comment 3

[Alex Cornestean]

Hello,

I reproduced the issue when attempting to submit the attached extension to AMO. As mentioned in the report, the add-on is rejected with the described errors. For further details, see the attached screenshot.

For reference, I tested this on the latest Beta (91.0b9/20210729185755) under Windows 10 x64.

Also, the add-on can be successfully loaded in the browser via about:debugging without any errors popping up when loading the add-on. However, some errors are logged in the add-on console after loading (see screenshot).

Comment 4

[Alex Cornestean]

Attachment: 2021-07-30_11h55_05.png

Comment 5

[Alex Cornestean]

Attachment: 2021-07-30_12h03_43.png

Comment 6

[[e-mail]]

Re-filed as https://github.com/mozilla/addons-linter/issues/3836 as the bugzilla components are only used for Firefox changes rather than service changes which are tracked on github.