Remove remaining uses of private slots
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox92 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(8 files, 4 obsolete files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Just debugger objects and WeakRefObject are left. These are a bit more tricky because they store GC things in the private slot to bypass the normal tracing code and/or compartment checks, but we can do something similar with PrivateValue.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D121177
Assignee | ||
Comment 3•3 years ago
|
||
This lets us change the implementation in later patches.
Depends on D121178
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D121179
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D121180
Assignee | ||
Comment 6•3 years ago
|
||
Depends on D121181
Assignee | ||
Comment 7•3 years ago
|
||
Depends on D121182
Assignee | ||
Comment 8•3 years ago
|
||
Depends on D121183
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e987ad3fbbd part 1 - Use a reserved slot instead of private slot for DebuggerFrame data. r=jonco https://hg.mozilla.org/integration/autoland/rev/0e1d1d582f1d part 2 - Use a reserved slot instead of private slot for DebugScriptObject script. r=jonco https://hg.mozilla.org/integration/autoland/rev/38a54851e501 part 3 - Add clearReferent to some debugger objects. r=jonco https://hg.mozilla.org/integration/autoland/rev/05d29352508e part 4 - Use a reserved slot instead of private slot for DebuggerEnvironment referent. r=jonco https://hg.mozilla.org/integration/autoland/rev/259ac80a5df4 part 5 - Use a reserved slot instead of private slot for DebuggerSource referent. r=jonco https://hg.mozilla.org/integration/autoland/rev/4485680c3c2f part 6 - Use a reserved slot instead of private slot for DebuggerScript referent. r=jonco https://hg.mozilla.org/integration/autoland/rev/981396167b01 part 7 - Use a reserved slot instead of private slot for DebuggerObject referent. r=jonco https://hg.mozilla.org/integration/autoland/rev/f4d19270f1f0 part 8 - Use a reserved slot instead of private slot for WeakRefObject target. r=jonco
Comment 10•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4e987ad3fbbd
https://hg.mozilla.org/mozilla-central/rev/0e1d1d582f1d
https://hg.mozilla.org/mozilla-central/rev/38a54851e501
https://hg.mozilla.org/mozilla-central/rev/05d29352508e
https://hg.mozilla.org/mozilla-central/rev/259ac80a5df4
https://hg.mozilla.org/mozilla-central/rev/4485680c3c2f
https://hg.mozilla.org/mozilla-central/rev/981396167b01
https://hg.mozilla.org/mozilla-central/rev/f4d19270f1f0
Assignee | ||
Comment 11•3 years ago
|
||
This replaces the JS_OFF_THREAD_CONSTRUCTOR MagicValue for off-thread constructors
with the same placeholder object we use for the prototype. These constructors
aren't used by off-thread parsing and handling this another way requires a lot
of complexity. With Stencil work the off-thread global will hopefully be removed
eventually.
Depends on D121992
Assignee | ||
Comment 12•3 years ago
|
||
Depends on D121993
Assignee | ||
Comment 13•3 years ago
|
||
This adds a few dereferences to the Baseline Interpreter, but is simpler and should
be faster for C++ accesses. It also simplifies/unblocks the next patch.
Depends on D121994
Assignee | ||
Comment 14•3 years ago
|
||
This is done last because it requires reordering the initialization code, and we
can finally do this now.
Depends on D121995
Comment 15•3 years ago
|
||
Comment on attachment 9235083 [details]
Bug 1722872 part 13 - Move builtin constructors to GlobalObjectData. r?jonco!
Revision D121993 was moved to bug 1723715. Setting attachment 9235083 [details] to obsolete.
Comment 16•3 years ago
|
||
Comment on attachment 9235084 [details]
Bug 1722872 part 14 - Clean up slot related code a bit. r?jonco!
Revision D121994 was moved to bug 1723715. Setting attachment 9235084 [details] to obsolete.
Comment 17•3 years ago
|
||
Comment on attachment 9235085 [details]
Bug 1722872 part 15 - Move global lexical environment from Realm to GlobalObjectData. r?jonco!
Revision D121995 was moved to bug 1723715. Setting attachment 9235085 [details] to obsolete.
Comment 18•3 years ago
|
||
Comment on attachment 9235086 [details]
Bug 1722872 part 16 - Move WindowProxy to GlobalObjectData. r?jonco!
Revision D121996 was moved to bug 1723715. Setting attachment 9235086 [details] to obsolete.
Description
•