1722878 - WIN - Enhanced Tracking Protection - ETP toggle button should have better color scheme on Dark Theme

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: 1.png

Affected versions

• 92.0a1 (2021-07-28)

Affected platforms

• Win10 (did not check on other OS's at this time)

Steps to reproduce

1. Launch Firefox, access any webpage;
2. Click on the About website button;
3. Observe and click on the ETP toggle button;

Expected result

• color scheme visible makes all elements visible;

Actual result

• White thumb on a light-blue toggle bar - poor visibility;

Enhancement suggestion(s)

1. change background to another shade of blue to increase visibility of thumb;
2. change background to white and thumb-color to something more visible;
3. add an border to the thumb-ring with another color to separate the elements better;

Regression range

• will poke QA team for further investigation;
• after the Proton overhaul;

Additional notes

• attached screenshot to better illustrate the area.

Comment 1

[Alin Ilea, Desktop Test Engineering [pto until 01.09]]

Hi,
Attaching the regression range made on Windows 10x64:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7d9da1b556ef25fbfac14270ba86e4b38a186f96&tochange=151716368f2cd98180e4e08acdc912218fbbbd75

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Hanna Jones [:hjones]]

Attachment: Currnet ETP toggle with dark theme applied

Comment 4

[Hanna Jones [:hjones]]

Marking this as resolved/fixed - since the fix for Bug 1801936 landed we're using a new toggle element that has higher contrast with dark theme applied (see attached screenshot).