1722888 - Allow BrowserTestUtils to handle https-first upgraded loads

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P1)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

Attachment: Bug 1722888: Allow BrowserTestUtils to handle https-first upgraded loads

Comment 2

[Christoph Kerschbaumer [:ckerschb}]

stealing that back...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8bc6abded4a
Allow BrowserTestUtils to handle https-first upgraded loads r=Gijs

Comment 4

[Iulian Moraru]

Backed out for causing bc failures on browser_preferences_usage.js.

Push with failures

Failure log

Backout link

Comment 5

[Christoph Kerschbaumer [:ckerschb}]

Gijs, do you think it would just work if we refactor the code to do something like if (wantLoad.startsWith("http://") and then nested within that if we do the getBoolPref so the pref is queried less often? As far as I can tell this is why the patch was backed out, because the pref is accessed too many times - or is there a better alternative in JS to cache the pref value?

Comment 6

[:Gijs (he/him)]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #5)

Gijs, do you think it would just work if we refactor the code to do something like if (wantLoad.startsWith("http://") and then nested within that if we do the getBoolPref so the pref is queried less often? As far as I can tell this is why the patch was backed out, because the pref is accessed too many times - or is there a better alternative in JS to cache the pref value?

XPCOMUtils.defineLazyPreferenceGetter(
  BrowserTestUtils,
  "_httpsFirstEnabled",
  "dom.security.https_first",
  false
);

after the definition of BrowserTestUtils in the jsm.

Then just check if (BrowserTestUtils._httpsFirstEnabled && wantLoad.startsWith("http://")) in the isWanted function.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba883fb40bed
Allow BrowserTestUtils to handle https-first upgraded loads r=Gijs

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ba883fb40bed