1722941 - Create view-model and use that instead of overloaded "profile"

Status: RESOLVED WONTFIX

(Toolkit :: Form Autofill, task, P3)

Description

[Tim Giles [:tgiles]]

As part of Bug 1687679, we noticed that we use this collection of records that is called "profile". I haven't been able to find documentation as to why this collection is called "profile" but this "profile" doesn't match the mental model across Firefox. This will cause confusion for developers familiar with Firefox Desktop development but those who are not familiar with this component.

The "profile" used in the Form Autofill component appears to be a view-model or presentation ready data, so we should update this accordingly or document what should and shouldn't be done to this data. For example, when working with credit cards, we have a model of name, credit card number, expiration month, expiration year, and card type. However, we generate credit card expiration date based on the autofill situation. I.e. is the form expecting "MM-YYYY", "MM/YY" or is the form using two separate elements for expiration month and year (in which case, we generate an expiration date string, but don't use it).

"profile" is used many times throughout this component, so this won't be a simple "find and replace" kind of exercise. I think a good starting point would be to change how this "profile" is named in the FormAutofillHandler.

Comment 1

[Sergey Galich [:serg]]

Indeed "profile" is a poor term for the job and it clashes with "profiles" in Firefox. We are moving toward a different model so this issue will be resolved by design there.