1722945 - Implement break-inside: avoid-{page,column}

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1722945 - Support break-inside: avoid-{page,column}. r=TYLin

break-before/after: page|column seem harder because you need to deal
with nested breaks, I think, but this should be straight-forward.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67c33ba5566e
Support break-inside: avoid-{page,column}. r=TYLin

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 67c33ba5566e (Bug 1722945) for causing bustage in nsContainerFrame.cpp

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=67c33ba5566e558513687692eeb7f3bbf6e07043&selectedTaskRun=F_n-xpl_QceZy1JU8rNvHg.0

Log: https://treeherder.mozilla.org/logviewer?job_id=347272229&repo=autoland&lineNumber=45072

Backout: https://hg.mozilla.org/integration/autoland/rev/a4b705497d98e2d64092cf614218f2fd18b4e409

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/507c4e968022
Support break-inside: avoid-{page,column}. r=TYLin

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/507c4e968022

Comment 6

[Andra Esanu]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67c33ba5566e
Support break-inside: avoid-{page,column}. r=TYLin

== Change summary for alert #30816 (as of Fri, 06 Aug 2021 11:02:38 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	sessionrestore	sessionrestore	linux1804-64-shippable-qr	e10s stylo webrender	558.84 -> 583.83
1%	sessionrestore	sessionrestore	linux1804-64-shippable-qr	e10s stylo webrender	577.83 -> 580.75
0.34%	sessionrestore	sessionrestore	linux1804-64-shippable-qr	e10s stylo webrender	557.38 -> 559.25

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30816

Comment 7

[Sebastian Zartner [:sebo]]

The related documentation updates are here:

Release notes: https://github.com/mdn/content/pull/7695
Browser compatibility data: https://github.com/mdn/browser-compat-data/pull/11924

Sebastian

Comment 9

[eoghan]

There appears to have been a regression on this, as it doesn't seem to work in Firefox 101.0.1
I'm going by https://stackoverflow.com/a/69164082/6691 which mentions that it was fixed in version 92.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

(In reply to eoghan from comment #9)

There appears to have been a regression on this, as it doesn't seem to work in Firefox 101.0.1
I'm going by https://stackoverflow.com/a/69164082/6691 which mentions that it was fixed in version 92.

"it doesn't seem to work" is a bit vague, can you file a new bug with a test-case? Happy to take a look. Thank you.