1722962 - Directly construct JS permanent atoms at startup

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

Currently the permanent atoms set is filled in by normal execution and atomization of the selfhosting data, and then in JSRuntime::initMainAtomsTables it is converted to the permanent set. Since we use Stencil for self-hosting now, the surface area for atom creation during startup is much much smaller and we should be able to directly construct the atom set.

This lets us remove special cases for early-startup from the AtomizeChars code.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 1: Split JSRuntime::initSelfHosting into compile part and instantiation part. r?tcampbell!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 2: Move JSRuntime::createJitRuntime call after permanent atom table initialization. r?tcampbell!

Depends on D133605

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 3: Split JSRuntime::InitSelfHostingFromStencil into atom part and other part. r?tcampbell!

Depends on D133606

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 4: Add JS::AutoAssertNoGC around atom/symbol initialization. r?tcampbell!

Depends on D133607

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 5: Fold JSRuntime::initSelfHostingAtomsFromStencil into JSRuntime::initializeAtoms. r?tcampbell!

Depends on D133608

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 6: Fold JSRuntime::initMainAtomsTables into JSRuntime::initializeAtoms. r?tcampbell!

Depends on D133610

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 7: Add PermanentlyAtomizeChars that skips zone cache. r?tcampbell!

Depends on D133612

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 8: Remove special case for permanent atom from AtomizeAndCopyCharsFromLookup. r?tcampbell!

Depends on D133613

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 9: Specialize AllocateNewAtom for permanent atoms. r?tcampbell!

Depends on D133614

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 10: Move AtomSet out of JSRuntime, and stop tracing. r?tcampbell!

Depends on D133615

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1722962 - Part 11: Inline well-known atom/symbol atomization. r?tcampbell!

Depends on D133616

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/378effea871d
Part 1: Split JSRuntime::initSelfHosting into compile part and instantiation part. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/964694eebaa9
Part 2: Move JSRuntime::createJitRuntime call after permanent atom table initialization. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/eac4e152c9ad
Part 3: Split JSRuntime::InitSelfHostingFromStencil into atom part and other part. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/318bec5fefa5
Part 4: Add JS::AutoAssertNoGC around atom/symbol initialization. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e30948486bcd
Part 5: Fold JSRuntime::initSelfHostingAtomsFromStencil into JSRuntime::initializeAtoms. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ad4cf3cdab04
Part 6: Fold JSRuntime::initMainAtomsTables into JSRuntime::initializeAtoms. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/325ee4e8c739
Part 7: Add PermanentlyAtomizeChars that skips zone cache. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/86e051127db1
Part 8: Remove special case for permanent atom from AtomizeAndCopyCharsFromLookup. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/11879610af4a
Part 9: Specialize AllocateNewAtom for permanent atoms. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e01b60ec09e8
Part 10: Move AtomSet out of JSRuntime, and stop tracing. r=tcampbell

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/378effea871d
https://hg.mozilla.org/mozilla-central/rev/964694eebaa9
https://hg.mozilla.org/mozilla-central/rev/eac4e152c9ad
https://hg.mozilla.org/mozilla-central/rev/318bec5fefa5
https://hg.mozilla.org/mozilla-central/rev/e30948486bcd
https://hg.mozilla.org/mozilla-central/rev/ad4cf3cdab04
https://hg.mozilla.org/mozilla-central/rev/325ee4e8c739
https://hg.mozilla.org/mozilla-central/rev/86e051127db1
https://hg.mozilla.org/mozilla-central/rev/11879610af4a
https://hg.mozilla.org/mozilla-central/rev/e01b60ec09e8