1723039 - Remove code-comments about "fully inflexible" from flex item definiteness checks

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P3)

Description

[Daniel Holbert [:dholbert]]

The flexbox spec has a note saying that fully-inflexible flex items with a definite flex-basis produce a definite main size.

We implemented this without the "fully-inflexible" requirement, due to webcompat needs, and I added code-comments about this disagreement from the spec here:
https://searchfox.org/mozilla-central/rev/699174544b058f13f02e7586b3c8fdbf438f084b/layout/generic/nsFlexContainerFrame.cpp#2167-2173
https://searchfox.org/mozilla-central/rev/699174544b058f13f02e7586b3c8fdbf438f084b/layout/generic/nsFlexContainerFrame.cpp#2130,2133-2135

Today the CSSWG resolved to match our behavior (to remove the fully-inflexible requirement) in https://github.com/w3c/csswg-drafts/issues/4311 , so we can remove these notes.

Comment 1

[Daniel Holbert [:dholbert]]

The CSSWG resolution is in https://github.com/w3c/csswg-drafts/issues/4311#issuecomment-889512146

The more-complete resolution is included in the IRC log, which is:

TabAtkins: we will add 4th condition to definiteness of flex items, that definite flex basis always make correspondign axis of flex item definite
TabAtkins: consequently can remove the note

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1723039: Remove obsolete code-comments about our flexbox implementation disagreeing with spec (now that spec has changed). r?TYLin

DONTBUILD

This patch doesn't impact behavior; it's just removing code-comments that refer
to a requirement in the spec that we don't honor, & which the CSSWG has now
resolved to remove (which makes our existing behavior correct & no longer
noteworthy).

The CSSWG resolution is in https://github.com/w3c/csswg-drafts/issues/4311 .
The new text is yet-to-be-written, but the main takeaway is that the "fully
inflexible" requirement (which we ignore) has been removed; so now, any flex
item with a definite flex-basis should have its main-size considered to be
definite. (And this matches our implementation.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79f0883a85a5
Remove obsolete code-comments about our flexbox implementation disagreeing with spec (now that spec has changed). r=TYLin

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/79f0883a85a5