1723076 - Allow larger items in the color cache texture

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Nicolas Silva [:nical]]

Currently any item that is wider or taller than 512 pixels goes into its own standalone texture. However we often generate linear gradient tasks with a height of 1 pixels and a width between 512 and 1024. Having them in standalone textures wastes a lot of memory and breaks batches. 1024 pixels fits exactly in the linear color cache texture.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1723076 - Allow larger items in the color cache textures. r=#gfx-reviewers

Before this patch any item that is wider or taller than 512 pixels goes into its own standalone texture. However we often generate linear gradient tasks with a height of 1 pixels and a width between 512 and 1024. Having them in standalone textures wastes a lot of memory and breaks batches. 1024 pixels fits exactly in the linear color cache texture.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25297aea1af5
Allow larger items in the color cache textures. r=gfx-reviewers,jrmuizel

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/25297aea1af5

Comment 4

[Andra Esanu (needinfo me)]

== Change summary for alert #30886 (as of Wed, 11 Aug 2021 11:41:24 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
11%	tresize		windows10-64-shippable-qr	e10s stylo webrender	7.43 -> 6.64
7%	tresize		windows10-64-shippable-qr	e10s stylo webrender	7.41 -> 6.88

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30886