1723150 - medium.com breaks with the Optimizely ETP shim

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[u608768]

STR

1. Set ETP to strict.
2. Visit https://medium.com.
3. Page content disappears after loading.

Console has "TypeError: can't access property "length", window.optimizely.get(...).getActiveExperimentIds() is undefined"

Something like

diff --git a/browser/extensions/webcompat/shims/optimizely.js b/browser/extensions/webcompat/shims/optimizely.js
--- a/browser/extensions/webcompat/shims/optimizely.js
+++ b/browser/extensions/webcompat/shims/optimizely.js
@@ -38,7 +38,7 @@ if (!window.optimizely?.state) {
 
   const state = {
     getActivationId() {},
-    getActiveExperimentIds() {},
+    getActiveExperimentIds() { return []; },
     getCampaignStateLists() {},
     getCampaignStates() {},
     getDecisionObject() {},

fixes this.

Comment 1

[u608768]

Attachment: Bug 1723150 - Fix the Optimizely shim for medium.com, r?twisniewski

It runs optimzely.get("state").getActiveExperimentIds().length, which blows up
when we don't return anything.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1714431

Comment 3

[Selena Deckelmann :selenamarie :selena]

Thank you! This has been bugging me for a few days :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/861b996fbea1
Fix the Optimizely shim for medium.com, r=twisniewski,webcompat-reviewers

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/861b996fbea1