Closed Bug 1723181 Opened 4 years ago Closed 4 years ago

"HasImageRequests" could be clearer in RefreshDriverTick profiler markers

Categories

(Core :: Web Painting, task)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

From looking around at the code and trying to understand the behavior, it seems we have "HasImageRequests" as the tick reason when the refresh driver is ticking because of animated images.

An example test case to reproduce this is loading about:preferences.

I'm proposing that in the profiler marker we rename "HasImageRequests" into the more self explanatory "HasImageAnimations", and that we add a new "Image Animation" marker (that name fits with the existing "Image Load" and "Image Paint" markers).

Example profile with the changes: https://share.firefox.dev/3ic5Hdq

See Also: → 1723188
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4fc8a8759035 Add an 'Image Animation' profiler marker, and rename the tick reason 'HasImageRequests' into 'HasImageAnimations' for clarity, r=mstange.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Regressions: 1735484
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: