1723187 - Startup Crash in [@ l10nregistry::source::FileSource::fetch_file_sync]

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

9 crashes from 9 different machines so far.

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/1479b6ec-f1cc-44f2-ab7b-3bbcd0210730

MOZ_CRASH Reason: [l10nregistry] Attempting to synchronously load file resource://app/localization/en-US/branding/brand.ftl while it's being loaded asynchronously.

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:17
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:91
2 xul.dll core::ops::function::Fn::call<fn ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/panicking.rs:595
4 xul.dll std::panicking::begin_panic_handler::{{closure}} ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/panicking.rs:497
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<closure-0, !> ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/sys_common/backtrace.rs:141
6 xul.dll std::panicking::begin_panic_handler ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/panicking.rs:493
7 xul.dll std::panicking::begin_panic_fmt ../53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b//library/std/src/panicking.rs:435
8 xul.dll l10nregistry::source::FileSource::fetch_file_sync third_party/rust/l10nregistry/src/source/mod.rs:257
9 xul.dll l10nregistry_ffi::source::l10nfilesource_fetch_file_sync intl/l10n/rust/l10nregistry-ffi/src/source.rs:266

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1723187 - Force sync load of a file if async load is in progress. r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1f2953ad605e
Force sync load of a file if async load is in progress. r=emilio a=nightly-fix

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1f2953ad605e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/349a7529d6cc
Force sync load of a file if async load is in progress. r=emilio

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/349a7529d6cc

Comment 6

[Julien Cristau [:jcristau]]

We're still crashing with these patches.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

We're still crashing with these patches.

I don't see a way for that to be possible. The crash description is associated with a single line that is not exercised with this patch.

Is there a chance that those crashes are from builds without the patch?

Comment 9

[Julien Cristau [:jcristau]]

We've got 4 crash reports so far that seem to be from the latest nightly (buildid 20210801214108):

• bp-93d5fc3f-3941-4d60-83fc-dc2ed0210802
• bp-8e40349e-0fa2-4153-a389-1807b0210802
• bp-ba6922a0-dbb8-4f2f-bafc-adb940210802
• bp-c7206dc5-c816-425a-abf9-741d10210802

The stacks point at https://hg.mozilla.org/mozilla-central/annotate/ea89827501c6f1abd7451f894221eebc367b2be0/third_party/rust/l10nregistry/src/source/mod.rs#l257

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

The stacks point at https://hg.mozilla.org/mozilla-central/annotate/ea89827501c6f1abd7451f894221eebc367b2be0/third_party/rust/l10nregistry/src/source/mod.rs#l257

Correct.

This line is only executed if the previous branch is not matched: https://hg.mozilla.org/mozilla-central/annotate/ea89827501c6f1abd7451f894221eebc367b2be0/third_party/rust/l10nregistry/src/source/mod.rs#l239

but with this patch the only callsite of this function calls overload true, so the line you listed should never be called.

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

ah, no, there's one more!

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Filing l10nregistry-rs issue to investigate: https://github.com/mozilla/l10nregistry-rs/issues/15

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1723187 - Update l10nregistry-rs to handle sync-during-async overload. r?emilio

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/940b5749ae17
Update l10nregistry-rs to handle sync-during-async overload. r=emilio

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/940b5749ae17

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is still being reported for today's Nightly (20210803094710) - should this bug be reopened?

Comment 17

[Zibi Braniecki [:zbraniecki][:gandalf]]

agh, yes! One more place! Grr.

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1723187 - Update l10nregistry-rs to handle sync-during-async overload, part2. r?emilio

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

I promise this is the last one... :)

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a60305db337
Update l10nregistry-rs to handle sync-during-async overload, part2. r=emilio

Comment 21

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4a60305db337