Closed Bug 1723204 Opened 4 months ago Closed 3 months ago

Collect additional data on difficult-to-reproduce occurrances

Categories

(Firefox :: Security, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Regressed 1 open bug)

Details

Attachments

(3 files)

We are logging telemetry for JavaScript loads that do not fit the expected chrome://, resource:// type of loads.

JavaScript load telemetry for 92 Nightly - for Windows-only[0] - shows

  • 2 users triggering 7 times on 'other'
  • 12 users triggering 90 times on 'other-on-worker'
  • 32 users triggering 606 times on a data url
  • 36 user triggering 37 time on about:preferences
  • 90 users triggering 141 times on about:downloads

After trynig to reproduce the about:preferences and about:downloads occurrances I cannot. I am not sure what additional information I could obtain through telemetry that would let me track down these instances except a stack trace. I am not 100% certain a stack trace would help, but it's my current best idea.

Delivering a stack trace without crashing is possible but would require a custom ping of some kind. An alternative is to just crash. These would be parent process crashes so they would bring down the whole browser unfortunately. We should be able to ensure a user would only crash at most once though.

[0] Windows has special additional telemetry details that allows us to separate out the Firefox Translation Telemetry Events (Bug 1722775) from the ones we are investigating here.

There's no way we could land this before Bug 1722775 because that would cause crashes for Translation users.

Depends on: 1722775

I confirmed the patches work (mostly?) as intended in a local build - the pref is updated and we crash. Then we don't anymore. The only thing I'm not certain about is that the crashes don't show up in about:crashes...

Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ee6c94f35b3
Infrastructure for causing a crash at most N times r=KrisWright,ckerschb
https://hg.mozilla.org/integration/autoland/rev/83e5baac01a9
Wire up a crash for Javascript Load Telemetry r=ckerschb,Gijs

This is most commonly as a result of CU.evalInSandbox which
allows an arbitrary filename but when omitted will default
to the filename of the test, which is a filesystem path
and thus is disallowed.

Depends on D121417

Attachment #9234050 - Attachment description: Bug 1723204: Infrastructure for causing a crash at most N times r?gijs → WIP: Bug 1723204: Infrastructure for causing a crash at most N times
Attachment #9234051 - Attachment description: Bug 1723204: Wire up a crash for Javascript Load Telemetry r?ckerschb,gijs → Bug 1723204: Wire up a crash for Javascript Load Telemetry r?ckerschb
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7e4042af76c
WIP: Bug 1723204: Infrastructure for causing a crash at most N times r=KrisWright,ckerschb,freddyb
https://hg.mozilla.org/integration/autoland/rev/4a20d1832cf4
Wire up a crash for Javascript Load Telemetry r=ckerschb,Gijs
https://hg.mozilla.org/integration/autoland/rev/df236c937895
Update tests to prevent crashes r=ckerschb,jdescottes,robwu
Regressions: 1727842
You need to log in before you can comment on or make changes to this bug.