Closed
Bug 1723417
Opened 4 years ago
Closed 4 years ago
Update spec steps comments in Promise.cpp
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
95 Branch
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(3 files)
Promise handling is heavily written based on abstract closure, and now many spec steps comments in Promise.cpp has no corresponding step in the spec.
we should update them, with using URLs instead of section numbers, that should make the future update easier.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D127475
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D127476
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/ff53b0396ff8
Part 1: Update comment for Promise internal and simple methods. r=yulia
https://hg.mozilla.org/integration/autoland/rev/4243f49b7cc1
Part 2: Update comment for Promise combinator methods. r=yulia
https://hg.mozilla.org/integration/autoland/rev/97213a181667
Part 3: Update comment for async functions. r=yulia
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ff53b0396ff8
https://hg.mozilla.org/mozilla-central/rev/4243f49b7cc1
https://hg.mozilla.org/mozilla-central/rev/97213a181667
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox95:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•