Closed Bug 1723466 Opened 3 years ago Closed 3 years ago

Pull the latest version of dump_syms so that we generate correct CFI directives on macOS

Categories

(Toolkit :: Crash Reporting, task)

All
macOS
task

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox-esr91 93+ fixed
firefox93 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

As per title, we need to pull at least version 7d3f4386528a422ba0c101498bd8bf1e5c5f2a3f which has the fix.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/39a44e619ecb
Import a new version of dump_syms that emits correct CFI information on macOS r=KrisWright
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Would this be useful to get on ESR91 also?

Flags: needinfo?(gsvelto)

Yes! Most definitely.

Flags: needinfo?(gsvelto)

[Tracking Requested - why for this release]:

Comment on attachment 9234237 [details]
Bug 1723466 - Import a new version of dump_syms that emits correct CFI information on macOS r=gankra

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This will make debugging macOS crashes in Firefox ESR easier
  • User impact if declined: It will be harder to diagnose macOS crashes
  • Fix Landed on Version: 93
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Firefox is unaffected, this only changes the symbol information we use to process crash reports
  • String or UUID changes made by this patch: none
Attachment #9234237 - Flags: approval-mozilla-esr91?

Comment on attachment 9234237 [details]
Bug 1723466 - Import a new version of dump_syms that emits correct CFI information on macOS r=gankra

Approved for 91.2esr.

Attachment #9234237 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: