1723487 - Support more number to string conversions in Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[Jon Coppeard (:jonco)]

We currently don't support conversions from ints or doubles to strings via String or new String:

https://searchfox.org/mozilla-central/source/js/src/jit/CacheIR.cpp#5995
https://searchfox.org/mozilla-central/source/js/src/jit/CacheIR.cpp#6021

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1723487 - Make EmitToStringGaurd into a method on IRGenerator r?jandem

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1723487 - Convert numberic arguments in calls to String and new String r?jandem

Depends on D121520

Comment 3

[Jon Coppeard (:jonco)]

I made a basic mircrobenchmark to test this:

Pre:
    String(int): 0.02919189453125 uS/iteration
    String(double): 0.105575927734375 uS/iteration
    new String(int): 0.0627861328125 uS/iteration
    new String(double): 0.145880126953125 uS/iteration

Post:
    String(int): 0.001093994140625 uS/iteration
    String(double): 0.100301025390625 uS/iteration
    new String(int): 0.032107177734375 uS/iteration
    new String(double): 0.102762939453125 uS/iteration

String(double) seems unaffected and I don't know why that is, but the others show improvement.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e7db0fb300e
Make EmitToStringGaurd into a method on IRGenerator r=jandem
https://hg.mozilla.org/integration/autoland/rev/79b0a5151478
Convert numberic arguments in calls to String and new String r=jandem

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5e7db0fb300e
https://hg.mozilla.org/mozilla-central/rev/79b0a5151478