Closed
Bug 1723537
Opened 3 years ago
Closed 3 years ago
Add `can_accept_markers` profiler API for Rust
Categories
(Core :: Gecko Profiler, enhancement, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
92 Branch
Tracking | Status | |
---|---|---|
firefox92 | --- | fixed |
People
(Reporter: canova, Assigned: canova)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
This will allow us to add markers API for Rust in the future. This API is a prerequisite for that, so we can have this check before adding a marker.
Assignee | ||
Comment 1•3 years ago
|
||
This is a prerequisite for adding a marker API. There is the same API for C++
as profiler_can_accept_markers
. This API can both be used as an external API
before adding an expensive payload to the profile marker, and it can be used as
an internal function to check it inside the new add_marker
API that will be
introduced soon.
Assignee | ||
Comment 2•3 years ago
|
||
Depends on D121535
Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1dfa66d34102 Add can_accept_markers profiler API for Rust r=emilio,gerald https://hg.mozilla.org/integration/autoland/rev/20eee5910768 Mention the MOZ_GECKO_PROFILER for macros/function that are no-op when it's not defined r=gerald
Comment 4•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1dfa66d34102
https://hg.mozilla.org/mozilla-central/rev/20eee5910768
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•