Open Bug 1723588 Opened 4 years ago Updated 4 years ago

Fix the AppMenu tests for new proton app menu structure

Categories

(Testing :: mozscreenshots, task)

Product:
Testing
Component:
mozscreenshots
Version:
Default
Type:
task

Tracking

(Not tracked)

People

(Reporter: sfoster, Unassigned)

Details

AppMenu.jsm has a set of tests that can be run against the browser's app menu (hamburger menu). These aren't in any default configuration set and are apparently rarely run as the change in https://hg.mozilla.org/mozilla-central/rev/c9872975bb5db34336b45cce538c16296db5f7d4 broke the reopenAppMenu helper back in 2020.

Once that is fixed, there are a few toolbarbutton lookups which no longer exist in the new appMenu:

  • #appMenu-library-button in the appMenuHistorySubview test
  • #appMenu-help-button in the appMenuHelpSubview

These need to be updated to point to an equivalent button and sub-view.

You can run these tests with:

$ MOZSCREENSHOTS_SETS=AppMenu ./mach test browser/tools/mozscreenshots/tests/browser/browser_screenshots.js
You need to log in before you can comment on or make changes to this bug.