1723614 - Make name change events more reliable and use them in markup name tests

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

Our EVENT_NAME_CHANGE should be more reliable. A first step would be to be able to rely on it for our own name mochitests.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1723614 - P1: Override DOMAttributeChanged where it makes sense. r?Jamie

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1723614 - P2: Robustify name change events and use events in name tests. r?Jamie

Changed the browser and mochitest name tests to rely exclusively on name change
events. To make this happen, I fixed all the cases where we were
event-deficient in the code:

• Examine target in PushNameOrDescriptionChange if it has eNameFromSubtreeRule.
  Fixes cases where a text change event happens with the subtree name root as target.
• Change in aria-labelledby should always result in a name change event because
  that attribute has highest prescedence.
• Add eHasNameDependent/eHasDescriptionDependent context flags when dependee accessible
  is added after dependent accessible to tree.
• Handle value attribute change in HTML buttons and determine if they should trigger a
  name changed event.
• Use accessible tree instead of content tree when calculating HTMLSelectOptionAccessible
  name, this keeps the PushNameOrDescriptionChange sees in name flags consistent with
  the actual tree.
• Handle label attribute change in select options and determine if they should trigger
  a name changed event.
• Determine if s summary attribute change on a table triggers a name change event.

Depends on D121579

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed2a183f7cad
P1: Override DOMAttributeChanged where it makes sense. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/72ed9a3fa104
P2: Robustify name change events and use events in name tests. r=Jamie

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ed2a183f7cad
https://hg.mozilla.org/mozilla-central/rev/72ed9a3fa104