1723679 - [de][Clear Recent History Modal] Selection Button is not aligned with other items

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P3)

Description

[Mehmet]

Attachment: Selection_Button_Actual_vs_Expected.png

Nightly 92.0a1 (2021-08-02) (64-Bit)
macOS

1.) Open a New Window
2.) Open the new Clear Recent History Modal
3.) Take a look at position of the Selection Button

Actual: The Selection Button is a bit too far right and not aligned with the other items

Expected: The Selection Button could be longer to start aligned with the other items

A screenshot is attached.

Thanks :)

Comment 1

[Itiel]

I think this is present only with the German locale, because it's the only locale that doesn't have any value for clear-time-duration-prefix.
Adding this:

#sanitizeDurationLabel[value=""] + #sanitizeDurationChoice {
  margin-inline-start: 0;
}

somewhere around sanitizeDialog.css should fix it, I think.

Comment 2

[Mehmet]

Attachment: about_preferences_privacy.png

Maybe also interesting: We have the same situation in about:preferences#privacy

Please see the attached screenshot.

Thanks.

Comment 3

[:Gijs (he/him)]

(In reply to Itiel from comment #1)

I think this is present only with the German locale, because it's the only locale that doesn't have any value for clear-time-duration-prefix.
Adding this:

#sanitizeDurationLabel[value=""] + #sanitizeDurationChoice {
  margin-inline-start: 0;
}

somewhere around sanitizeDialog.css should fix it, I think.

I think this is bang on the money. Let's make this a mentored bug. :-)

Comment 4

[onuohaoluebube05]

Hello, I am an outreachy applicant.

Can you please assign me to this bug

Thanks

Comment 5

[:Gijs (he/him)]

(In reply to onuohaoluebube05 from comment #4)

Hello, I am an outreachy applicant.

Can you please assign me to this bug

Thanks

We normally assign bugs when they have a patch up. It looks like you've commented on about 10 different bugs; please pick one to work on.

Comment 6

[Leslie]

Attachment: Bug 1723679 - Align Selection Button with other items. r?Gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6131b89a5d8
Align Selection Button with other items. r=Gijs

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a6131b89a5d8

Comment 9

[Mehmet]

Attachment: 95.0a1 (2021-10-21) (64-Bit).png

Thanks :-) The fix is working as expected in Nightly 95.0a1 (2021-10-21) (64-Bit)