1723691 - Surface the WindowsErrorReporting annotation and make it searchable

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[Gabriele Svelto [:gsvelto]]

In bug 1703761 I've added an annotation to identify crashes captured by the Windows Error Reporting runtime exception module. The annotation is currently private on Socorro and cannot be searched. Given the annotation doesn't contain anything privacy sensitive (it's just a boolean) I'd like it to be publicly visible and searchable.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do this week.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I looked at a handful of crash reports and I think this currently has two "values":

1. the annotation is there and the value is "1"
2. the annotation is not there

How do we want to search with this? Do we want to do, "Show me crashes where WER is 1"? How about, "Show me crashes where WER is not 1"? How about, "Show me crashes where WER is missing"?

Do we want to do aggregations? Maybe something like "Show me a breakdown of WER values for crashes that meet some criteria" that shows "0", "1", and missing?

Comment 3

[Gabriele Svelto [:gsvelto]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #2)

1. the annotation is there and the value is "1"
2. the annotation is not there

Yes, that's the only two possibilities basically. I used "1" when present because that's what we use for booleans historically. The "0" value would be redundant so crashes that don't have it can assume it's 0.

How do we want to search with this? Do we want to do, "Show me crashes where WER is 1"? How about, "Show me crashes where WER is not 1"? How about, "Show me crashes where WER is missing"?

My use case is "show me cases where WER is present (I already know it's 1 when it's present so that's not really important)" which translates t o "show me all the crashes we captured via WER". Aggregations are not needed because it's just a boolean flag.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ok, given that, I'll implement it so that it'll work like this:

1. if the crash annotation is there and is a "1", it'll get indexed and you can search for it
2. if the crash annotation is there and it is not a "1", it won't get indexed (it'll be missing) and a processor note will be added about how it's a non-"1" value
3. if the crash annotation is not there, it won't get indexed--it'll be missing

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5844: bug 1723691: make windows_error_reporting searchable

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5844: "bug 1723691: make windows_error_reporting searchable" in 5a7c9d1.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this out in bug #1724703 just now. Marking as FIXED.

The annotation is visible now, however, it won't be searchable until next week when a new index is created.