1723725 - SessionStoreCache tries to use SessionStore.promiseAllWindowsRestored as a method, but it's a getter (TypeError: SessionStore.promiseAllWindowsRestored is not a function)

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[:Gijs (he/him)]

As per summary. https://searchfox.org/mozilla-central/rev/4f05a46731c1f7f111ec7a41ce38a34594aa0d37/browser/components/sessionstore/SessionWorkerCache.jsm#111 should lose the (), but I don't know what that's going to break...

Doug, can you take a look?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1546847

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1723725 - Fix SessionWorkerCache import cleanup r?Gijs

The effect of this bug should be a slow leak of unreferenced cache entries
between sessions. After the fix we should just be appropriately cleaning them
up.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8347fc2ff27
Fix SessionWorkerCache import cleanup r=Gijs

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset a8347fc2ff27 (Bug 1723725) for causing failures in browser_sessionWorkerCacheImport.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=BP8As0NvRdOHAnnAA60u4Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a8347fc2ff2790d04114cc1dd5673a20e83342de

Log: https://treeherder.mozilla.org/logviewer?job_id=347289424&repo=autoland&lineNumber=3157

Backout: https://hg.mozilla.org/integration/autoland/rev/630292a48dd93b79d803462a85a0402f0d9ef7a4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cedf25cf0651
Fix SessionWorkerCache import cleanup r=Gijs

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cedf25cf0651