Closed Bug 1723727 Opened 4 years ago Closed 4 years ago

Intermittent Android TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(50vh 100vh) - computed - expected FAIL

Categories

(Core :: Layout: Floats, defect, P5)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox90 --- unaffected
firefox91 --- unaffected
firefox92 --- wontfix
firefox93 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=347239538&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OaXGP6o0T8GlOihZO0cRvg/runs/0/artifacts/public/logs/live_backing.log


[task 2021-08-03T10:25:29.343Z] 10:25:29     INFO - TEST-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vw - ellipse(25vw farthest-side) - computed 
[task 2021-08-03T10:25:29.343Z] 10:25:29     INFO - TEST-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vw - ellipse(farthest-side 75vw) - computed 
[task 2021-08-03T10:25:29.343Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(50vh 100vh) - computed - expected FAIL
[task 2021-08-03T10:25:29.343Z] 10:25:29     INFO - TEST-INFO | expected FAIL
[task 2021-08-03T10:25:29.344Z] 10:25:29     INFO - 
[task 2021-08-03T10:25:29.344Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(100vh 100px) - computed - expected FAIL
[task 2021-08-03T10:25:29.344Z] 10:25:29     INFO - TEST-INFO | expected FAIL
[task 2021-08-03T10:25:29.345Z] 10:25:29     INFO - 
[task 2021-08-03T10:25:29.345Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(50vh 25%) - computed - expected FAIL
[task 2021-08-03T10:25:29.345Z] 10:25:29     INFO - TEST-INFO | expected FAIL
[task 2021-08-03T10:25:29.346Z] 10:25:29     INFO - 
[task 2021-08-03T10:25:29.346Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(25% 50vh) - computed - expected FAIL
[task 2021-08-03T10:25:29.346Z] 10:25:29     INFO - TEST-INFO | expected FAIL
[task 2021-08-03T10:25:29.347Z] 10:25:29     INFO - 
[task 2021-08-03T10:25:29.347Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(25vh closest-side) - computed - expected FAIL
[task 2021-08-03T10:25:29.347Z] 10:25:29     INFO - TEST-INFO | expected FAIL
[task 2021-08-03T10:25:29.347Z] 10:25:29     INFO - 
[task 2021-08-03T10:25:29.347Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(closest-side 75vh) - computed - expected FAIL
[task 2021-08-03T10:25:29.347Z] 10:25:29     INFO - TEST-INFO | expected FAIL
[task 2021-08-03T10:25:29.348Z] 10:25:29     INFO - 
[task 2021-08-03T10:25:29.348Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(25vh farthest-side) - computed - expected FAIL
[task 2021-08-03T10:25:29.348Z] 10:25:29     INFO - TEST-INFO | expected FAIL
[task 2021-08-03T10:25:29.349Z] 10:25:29     INFO - 
[task 2021-08-03T10:25:29.349Z] 10:25:29     INFO - TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(farthest-side 75vh) - computed - expected FAIL
[task 2021-08-03T10:25:29.349Z] 10:25:29     INFO - TEST-INFO | expected FAIL

Intermittent unexpected passes. This could just be annotated but do we know what caused this change to intermittent test results?

Summary: Intermittent TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(50vh 100vh) - computed - expected FAIL → Intermittent Android TEST-UNEXPECTED-PASS | /css/css-shapes/shape-outside/values/shape-outside-ellipse-005.html | test unit: vh - ellipse(50vh 100vh) - computed - expected FAIL

Sorry for the late reply. There's no recent change related to shapes or floats that I know of. Given the intermittent all happens on Android and the tests have viewport units like vh and vm, I guess it is related to Android viewport handling.

(cc Hiro)

Flags: needinfo?(aethanyc)

I seems to have missed the CC in comment 3. I know the change makes this test pass occasionally, it's bug 1718012. With bug 1718012, auto-scaling on mobile happens earlier than before, which makes the test more stable.

That said, that's not a proper solution on these kind of failure. We should just specify a meta viewport tag to avoid auto-scaling. If there's no meta viewport tag, the document will be laid out on 980px width canvas, it is going to be scaled to fit the device screen width, it happens during reflows, thus in the middle of the reflows the viewport units are not stable.

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED

Hiro, thanks for looking into this!

I was wondering whether bug 1723671, bug 1723726, bug 1723736, bug 1723739, and bug 1723740 are the same issue. Maybe we can add the viewport tag to every tests under /css/css-shapes/shape-outside/values/ to fix them all.

Flags: needinfo?(hikezoe.birchill)

Yeah looks like all the bugs are same. I will add them in this bug. Thanks for noticing!

Flags: needinfo?(hikezoe.birchill)

Looks like I've already included some of them. :)

Attachment #9237596 - Attachment description: Bug 1723727 - Specify a meta viewport tag in shape-outside-ellipse-xxx.htmls to avoid auto-scaling on mobile. r?TYLin → Bug 1723727 - Specify a meta viewport tag to each files in /css/css-shapes/shape-outside/values/ to avoid auto-scaling on mobile. r?TYLin
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30163 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: