1723741 - Recorded SVG image blobs don't display in taskbar

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

STR:

1. Flip image.svg.blob-image to true
2. Restart Firefox.
3. Icons in the taskbar are missing.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

This should only trigger when there is something other than an integer translation:

https://searchfox.org/mozilla-central/rev/4f05a46731c1f7f111ec7a41ce38a34594aa0d37/gfx/thebes/gfxUtils.cpp#531

But the only thing we do to the gfxContext transform is what should be an integer translation:

https://searchfox.org/mozilla-central/rev/4f05a46731c1f7f111ec7a41ce38a34594aa0d37/image/SourceSurfaceBlobImage.cpp#212

There are some floating point conversions here that might be getting in the way.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

The signature differs from what I wrote:

https://searchfox.org/mozilla-central/rev/4f05a46731c1f7f111ec7a41ce38a34594aa0d37/gfx/thebes/gfxUtils.h#106

I guess I fixed the test case accidentally by setting the opacity to completely transparent, and shortcutting somewhere....

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1723741 - Fix how SVG images in blob recordings would always be transparent.

This occurred due to a signature mismatch with
gfxUtils::DrawPixelSnapped. A previous patch in bug 1712855 put the
wrong field in the opacity parameter. It implicitly converted a bool to
a float silently, causing the opacity to be 0.0.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa3677b2a1e5
Fix how SVG images in blob recordings would always be transparent. r=gfx-reviewers,jrmuizel

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fa3677b2a1e5