Closed Bug 1723921 Opened 3 years ago Closed 3 years ago

Update getComputedStyle with unknown pseudos to the spec.

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox92 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

Per https://github.com/w3c/csswg-drafts/issues/2149 we should throw on invalid pseudo-elements. Let's try this behavior on Nightly.

This will make implementing the new behavior behind a pref
really straight-forward, and is generally nicer.

With the patch above, some devtools tests failed because we were trying
to call getComputedStyle(node, ":marker") (read: one colon rather than
two).

Using two colons for pseudo-elements is the right thing to do and fixes
it / removes some weird special-cases.

Keywords: leave-open
Blocks: 1724235
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e55c2177bbd2
Make devtools use two colons for pseudo-elements consistently. r=jdescottes
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/5e9348094ee1
Fix test_getCSSPseudoElementNames.

Yeah, this depends on the other patch to work.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c6d6481a449
Cleanup nsComputedDOMStyle and related APIs. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/a3bbc3330c2e
Make devtools use two colons for pseudo-elements consistently. r=jdescottes
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9d140e0e045
Throw on invalid pseudo-elements in getComputedStyle() as per spec. r=dholbert,layout-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29941 for changes under testing/web-platform/tests
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Regressions: 1724626
Upstream PR merged by moz-wptsync-bot
Regressions: 1724652
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: